Skip to content

Fix Monitor Integration Test Flake: added wait until expected text value to be present #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtaylor113 wants to merge 1 commit into from
Closed

Fix Monitor Integration Test Flake: added wait until expected text value to be present #4012

dtaylor113 wants to merge 1 commit into from

Conversation

@dtaylor113
Copy link
Contributor

@dtaylor113 dtaylor113 commented Jan 20, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 20, 2020

Frontend change looks good, still have this for backend:

go: finding google.golang.org/genproto v0.0.0-20190819201941-24fa4b261c55
/go/pkg/mod/github.com/coreos/pkg@v0.0.0-20180928190104-399ea9e2e55f/capnslog/journald_formatter.go:25:2: no matching versions for query "latest"

spadgett
spadgett reviewed Jan 20, 2020
View reviewed changes
@dtaylor113 dtaylor113 force-pushed the fix-monitoring-test-flake branch from 282425a to 6cf6669 Compare January 20, 2020 17:55
spadgett
spadgett approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 20, 2020
@spadgett
Copy link
Member

spadgett commented Jan 20, 2020

/kind test-flake

@openshift-ci-robot openshift-ci-robot added the kind/test-flake Categorizes issue or PR as related to test flakes. label Jan 20, 2020
@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Jan 20, 2020

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Jan 20, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@dtaylor113 dtaylor113 force-pushed the fix-monitoring-test-flake branch from 6cf6669 to 25f2d9c Compare January 21, 2020 14:01
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 21, 2020

New changes are detected. LGTM label has been removed.

@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Jan 21, 2020

Hi @spadgett, added a waitForCount for latest flake. Wish I could reproduce these locally.

@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Jan 21, 2020

/retest

@dtaylor113 dtaylor113 force-pushed the fix-monitoring-test-flake branch from 25f2d9c to 64fdddd Compare January 22, 2020 13:56
@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Jan 23, 2020 •
edited
Loading

Hi @spadgett, not sure what to do with this PR 🤔

@dtaylor113 dtaylor113 mentioned this pull request Jan 24, 2020
Merged
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Jan 24, 2020

I think its uncertain if this is needed now. We aren't seeing the flake anymore elsewhere.

@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Jan 24, 2020

I think its uncertain if this is needed now. We aren't seeing the flake anymore elsewhere.

Hi, @benjaminapetersen thought this was another flake, I'll retest.

@dtaylor113
Copy link
Contributor Author

dtaylor113 commented Jan 24, 2020

Not needed

@dtaylor113 dtaylor113 closed this Jan 24, 2020
@dtaylor113 dtaylor113 deleted the fix-monitoring-test-flake branch April 27, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/test-flake Categorizes issue or PR as related to test flakes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@dtaylor113 @benjaminapetersen @openshift-ci-robot @spadgett @openshift-bot