Add events and alerts to monitoring tab on overview page #4036

vikram-raj · 2020-01-22T11:36:11Z

Stories - https://issues.redhat.com/browse/ODC-2596 and https://issues.redhat.com/browse/ODC-2600

This PR adds the Alerts and Events section under the monitoring tab of the overview panel.

vikram-raj · 2020-01-22T11:37:23Z

/kind feature

serenamarie125

Please change the "Events" accordion to say "All Events"
Please change the "Alerts" section to "Events (Warning)", and only show the warning level events

vikram-raj · 2020-01-23T11:20:16Z

Please change the "Events" accordion to say "All Events"
Please change the "Alerts" section to "Events (Warning)", and only show the warning level events

@serenamarie125 I rename the accordion and keep metrics accordion expanded by default as per your requested changes.

abhi-kn · 2020-01-23T11:54:47Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverview.tsx

nit: Better if renamed as MonitoringMetrics & moved to separate file.

abhi-kn · 2020-01-23T12:27:26Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringOverview.tsx

Better if we move each AccordionItem into specific section components

I already added separate component for events (Warning), Metrics, Events. I added AccordianItem here so that state can be maintained for the accordion.

abhi-kn · 2020-01-23T12:28:23Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringTab.tsx

MonitoringMetricsSection has been renamed. Use MonitoringOverview

abhi-kn · 2020-01-23T12:30:08Z

...s/dev-console/src/components/monitoring/overview/__tests__/MonitoringMetricsSection.spec.tsx

Import appropriate module name & also rename the spec file.

abhi-kn · 2020-01-23T12:30:37Z

...end/packages/dev-console/src/components/monitoring/overview/__tests__/MonitoringTab.spec.tsx

same as above comment

invincibleJai · 2020-01-23T15:48:45Z

frontend/packages/dev-console/src/components/monitoring/overview/MonitoringEvents.tsx

nit: odc-monitoring-event should odc-monitoring-events based on filename

invincibleJai · 2020-01-23T16:12:53Z

All looks good , one css issue

vikram-raj · 2020-01-23T16:19:49Z

All looks good , one css issue

Thanks @invincibleJai Fixed this.

invincibleJai · 2020-01-23T16:20:25Z

/lgtm

debsmita1 · 2020-01-23T17:24:59Z

tested this locally and it works fine
/lgtm

serenamarie125

thanks for doing the rework! This looks great

christianvogt · 2020-01-24T01:47:11Z

/approve

openshift-ci-robot · 2020-01-24T01:47:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, debsmita1, invincibleJai, serenamarie125, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-24T02:26:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-24T02:52:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2020

openshift-ci-robot requested review from divyanshiGupta and vojtechszocs January 22, 2020 11:36

openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. component/core Related to console core functionality component/dev-console Related to dev-console component/sdk Related to console-plugin-sdk labels Jan 22, 2020

serenamarie125 suggested changes Jan 22, 2020

View reviewed changes

vikram-raj force-pushed the monitoring-alert-event branch 2 times, most recently from 29c6b97 to 50dcd81 Compare January 23, 2020 08:01

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2020

vikram-raj force-pushed the monitoring-alert-event branch 3 times, most recently from bc973e5 to 701037c Compare January 23, 2020 10:51

openshift-ci-robot added the component/shared Related to console-shared label Jan 23, 2020

vikram-raj force-pushed the monitoring-alert-event branch from 701037c to f85bb20 Compare January 23, 2020 11:03

vikram-raj changed the title ~~[WIP] add events and alerts to monitoring tab on overview page~~ Add events and alerts to monitoring tab on overview page Jan 23, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020

vikram-raj force-pushed the monitoring-alert-event branch from f85bb20 to 2fb8c94 Compare January 23, 2020 12:31

vikram-raj requested a review from serenamarie125 January 23, 2020 12:32

vikram-raj force-pushed the monitoring-alert-event branch from 2fb8c94 to 7ab90b1 Compare January 23, 2020 13:04

abhi-kn reviewed Jan 23, 2020

View reviewed changes

vikram-raj force-pushed the monitoring-alert-event branch 2 times, most recently from 34483cc to 89b96d8 Compare January 23, 2020 15:42

invincibleJai reviewed Jan 23, 2020

View reviewed changes

vikram-raj force-pushed the monitoring-alert-event branch from 89b96d8 to af8a0e6 Compare January 23, 2020 16:06

add events and alerts to monitoring tab on overview page

15c2e1f

vikram-raj force-pushed the monitoring-alert-event branch from af8a0e6 to 15c2e1f Compare January 23, 2020 16:18

openshift-ci-robot assigned invincibleJai Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

openshift-ci-robot assigned debsmita1 Jan 23, 2020

serenamarie125 approved these changes Jan 23, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2020

openshift-merge-robot merged commit 20a757d into openshift:master Jan 24, 2020

vikram-raj deleted the monitoring-alert-event branch January 24, 2020 05:49

spadgett added this to the v4.4 milestone Jan 27, 2020

Add events and alerts to monitoring tab on overview page #4036

Add events and alerts to monitoring tab on overview page #4036

Uh oh!

Conversation

vikram-raj commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikram-raj commented Jan 22, 2020

Uh oh!

serenamarie125 left a comment

Choose a reason for hiding this comment

Uh oh!

vikram-raj commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

invincibleJai commented Jan 23, 2020

Uh oh!

vikram-raj commented Jan 23, 2020

Uh oh!

invincibleJai commented Jan 23, 2020

Uh oh!

debsmita1 commented Jan 23, 2020

Uh oh!

serenamarie125 left a comment

Choose a reason for hiding this comment

Uh oh!

christianvogt commented Jan 24, 2020

Uh oh!

openshift-ci-robot commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

openshift-bot commented Jan 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

vikram-raj commented Jan 22, 2020 •

edited

Loading

vikram-raj commented Jan 23, 2020 •

edited

Loading