Alertmanager: Advanced configuration fields #4044

dtaylor113 · 2020-01-22T19:54:28Z

Added advanced configuration fields within expand/collapse section on each receiver form.

Screenshots

dtaylor113 · 2020-03-11T20:43:20Z

Hi @benjaminapetersen, @kyoto, and @spadgett, I believe this PR is ready to be reviewed.

benjaminapetersen · 2020-03-17T15:20:21Z

/hold

We need to know if the API is going to change on this, and if monitoring is working on that at this point. If it changes, we may want to revise to the new API rather than merging right now.

spadgett · 2020-04-17T15:21:43Z

/hold cancel

spadgett · 2020-04-17T15:24:31Z

frontend/integration-tests/views/monitoring.view.ts

nit: Let's spell out the word. It's already a long name and editors have autocomplete.

Suggested change

export const showAdvConfiguration = $('button.pf-c-expandable__toggle');

export const showAdvancedConfiguration = $('button.pf-c-expandable__toggle');

spadgett · 2020-04-17T15:27:07Z

frontend/public/components/monitoring/receiver-forms/alert-manager-receiver-forms.tsx

Either use the PF4 check or Bootstrap checkbox class instead of co-no-bold.

spadgett · 2020-04-17T15:27:57Z

frontend/public/components/monitoring/receiver-forms/alert-manager-receiver-forms.tsx

  shouldn't be needed if you use the checkbox component or Bootstrap checkbox classes.

spadgett · 2020-04-17T15:29:38Z

frontend/public/components/monitoring/receiver-forms/slack-receiver-form.tsx

Suggested change

title="Url"

title="URL"

spadgett · 2020-04-17T15:30:12Z

frontend/public/components/monitoring/receiver-forms/slack-receiver-form.tsx

All of the help blocks should have punctuation to be consistent with other forms in console (although it looks like existing help blocks for Alertmanager is missing that).

Suggested change

The url of the icon

The URL of the icon.

spadgett · 2020-04-17T15:36:38Z

frontend/public/components/monitoring/receiver-forms/pagerduty-receiver-form.tsx

Suggested change

Description of the incident

Description of the incident.

spadgett · 2020-04-17T15:36:48Z

frontend/public/components/monitoring/receiver-forms/pagerduty-receiver-form.tsx

spadgett · 2020-04-17T15:36:54Z

frontend/public/components/monitoring/receiver-forms/pagerduty-receiver-form.tsx

Suggested change

Severity of the incident

Severity of the incident.

spadgett · 2020-04-17T15:37:29Z

frontend/public/components/monitoring/receiver-forms/email-receiver-form.tsx

spadgett · 2020-04-17T15:38:29Z

frontend/public/components/monitoring/receiver-forms/email-receiver-form.tsx

Use consistent case for all labels

Suggested change

Body of email notifications (HTML)

Body of Email Notifications (HTML)

dtaylor113 · 2020-04-17T19:19:47Z

Hi @spadgett, I believe I have addressed all of your review comments. Last commit has just those changes. Monitoring and Alertmanager integration tests passed locally -thanks

spadgett

/lgtm

openshift-ci-robot · 2020-04-17T20:31:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

spadgett · 2020-04-17T21:49:14Z

/hold
for #5100

spadgett · 2020-04-17T23:17:42Z

/hold cancel
/retest

dtaylor113 · 2020-04-18T13:38:00Z

/retest

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2020

dtaylor113 requested a review from spadgett January 22, 2020 19:54

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Jan 22, 2020

dtaylor113 mentioned this pull request Jan 22, 2020

Alertmanager: Added Email and Slack Receiver forms, implemented Save-As-Global/Default functionality #4041

Merged

openshift-ci-robot requested a review from jhadvig January 22, 2020 19:56

dtaylor113 changed the title ~~[WIP] Alertmanager: Added advanced configuration fields~~ [WIP] Alertmanager: Advanced configuration fields Jan 22, 2020

dtaylor113 force-pushed the alertmanager-advanced-configuration-fields branch 3 times, most recently from 94fda80 to 2f355a1 Compare January 24, 2020 20:19

openshift deleted a comment from openshift-ci-robot Jan 24, 2020

dtaylor113 force-pushed the alertmanager-advanced-configuration-fields branch from 2f355a1 to 251a43d Compare January 27, 2020 16:12

spadgett added this to the v4.5 milestone Jan 29, 2020

dtaylor113 changed the base branch from master to release-4.5 January 29, 2020 13:59

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2020

benjaminapetersen changed the title ~~[WIP] Alertmanager: Advanced configuration fields~~ [WIP] Alertmanager: Advanced configuration fields [4.5] Jan 29, 2020

dtaylor113 force-pushed the alertmanager-advanced-configuration-fields branch from 251a43d to 7b9b05e Compare January 29, 2020 17:06

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2020

dtaylor113 changed the title ~~[WIP] Alertmanager: Advanced configuration fields [4.5]~~ Alertmanager: Advanced configuration fields [4.5] Jan 29, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2020

dtaylor113 changed the base branch from release-4.5 to master March 10, 2020 19:52

dtaylor113 requested review from benjaminapetersen, cshinn and kyoto March 11, 2020 20:43

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2020

dtaylor113 force-pushed the alertmanager-advanced-configuration-fields branch from 7b9b05e to 2ffc326 Compare March 25, 2020 14:17

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020

spadgett changed the title ~~Alertmanager: Advanced configuration fields [4.5]~~ Alertmanager: Advanced configuration fields Apr 17, 2020

spadgett requested changes Apr 17, 2020

View reviewed changes

dtaylor113 force-pushed the alertmanager-advanced-configuration-fields branch from 2ffc326 to 20ec311 Compare April 17, 2020 19:17

Alertmanager: Added advanced fields to receiver forms

1bc5bb7

dtaylor113 force-pushed the alertmanager-advanced-configuration-fields branch from 20ec311 to 1bc5bb7 Compare April 17, 2020 20:21

spadgett approved these changes Apr 17, 2020

View reviewed changes

openshift-ci-robot assigned spadgett Apr 17, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020

openshift-merge-robot merged commit d2c48b4 into openshift:master Apr 18, 2020

dtaylor113 deleted the alertmanager-advanced-configuration-fields branch April 27, 2020 14:15

	export const showAdvConfiguration = $('button.pf-c-expandable__toggle');
	export const showAdvancedConfiguration = $('button.pf-c-expandable__toggle');

	Body of email notifications (HTML)
	Body of Email Notifications (HTML)

Alertmanager: Advanced configuration fields #4044

Alertmanager: Advanced configuration fields #4044

Uh oh!

Conversation

dtaylor113 commented Jan 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtaylor113 commented Mar 11, 2020

Uh oh!

benjaminapetersen commented Mar 17, 2020

Uh oh!

spadgett commented Apr 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dtaylor113 commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 17, 2020

Uh oh!

spadgett commented Apr 17, 2020

Uh oh!

spadgett commented Apr 17, 2020

Uh oh!

dtaylor113 commented Apr 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dtaylor113 commented Jan 22, 2020 •

edited

Loading

dtaylor113 commented Apr 17, 2020 •

edited

Loading