feat(operator-grouping): add operator grouping in topology #4048

karthikjeeyar · 2020-01-23T00:07:28Z

This PR supports Operator backed services grouping in topology.

Supports for multiple grouping

Todo

Add Icon to the group

Add unit test cases

cc: @openshift/team-devconsole-ux @serenamarie125 @christianvogt

Fixes: https://issues.redhat.com/browse/ODC-2699

karthikjeeyar · 2020-01-23T09:18:55Z

/retitle feat(operator-grouping): add operator grouping in topology

karthikjeeyar · 2020-01-23T09:28:35Z

/assign @christianvogt

karthikjeeyar · 2020-01-23T09:28:55Z

/kind feature

divyanshiGupta · 2020-01-23T10:31:33Z

...end/packages/dev-console/src/components/topology/components/nodes/OperatorBackedService.scss

Use pf variables (https://www.patternfly.org/v4/documentation/overview/global-css-variables) wherever possible.

divyanshiGupta · 2020-01-23T10:32:28Z

...tend/packages/dev-console/src/components/topology/components/nodes/OperatorBackedService.tsx

Move it to the end of imports

divyanshiGupta · 2020-01-23T10:42:58Z

frontend/packages/dev-console/src/components/topology/topology-utils.ts

So we create operatorBackedServiceKindMap using the installedOperators, if operator is not present in installedOperators then it will not be present in operatorBackedServiceKindMap. Am I missing anything?

we create operatorBackedServiceKindMap(CRD map) out of installedOperators's crds, which can be used to identify the resources created by the crd. But when you install an operator, the operator creates a resource (eg: postgres-operator) which will have ownerReference of the installed operator(csv). We need to group the nodes created by operator & its crds together.

Based on a resource's owner reference, this will choose from installedOperators or its crds operatorBackedServiceKindMap

Got it. Forgot about the case of the operator node :P Then it makes sense to look for the csv itself in the installed operators list.

jeff-phillips-18 · 2020-01-23T11:55:28Z

...end/packages/dev-console/src/components/topology/components/nodes/OperatorBackedService.scss

Doesn't appear there is any click nor drag action on service, so there shouldn't be a pointer cursor.

jeff-phillips-18 · 2020-01-23T11:55:35Z

...tend/packages/dev-console/src/components/topology/components/nodes/OperatorBackedService.tsx

The factory is not adding withDndDrop or withDragNode so a lot of these props will not be passed.

removed it.

karthikjeeyar · 2020-01-23T13:21:46Z

frontend/packages/dev-console/src/components/svg/SvgBoxedText.tsx

@jeff-phillips-18 FYI, I have this use case where i have data:url from the csv instead of icon name. I believe you have the proper icon alignment in one of your PRs.

thanks, I'll be sure to adjust.

andrewballantyne · 2020-01-25T06:40:45Z

I wanna say this is a flake...

/test frontend

andrewballantyne · 2020-01-25T07:34:03Z

/lgtm

andrewballantyne · 2020-01-25T07:41:08Z

/lgtm

openshift-ci-robot · 2020-01-25T07:41:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, divyanshiGupta, jeff-phillips-18, karthikjeeyar, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karthikjeeyar · 2020-01-25T08:05:20Z

/test analyze

andrewballantyne · 2020-01-25T09:15:30Z

/retest

openshift-bot · 2020-01-25T10:43:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T10:56:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

karthikjeeyar · 2020-01-25T14:41:11Z

/retest

openshift-bot · 2020-01-25T15:28:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T18:06:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

andrewballantyne · 2020-01-25T18:25:00Z

/hold

All the checks are failing atm
https://coreos.slack.com/archives/CEKNRGF25/p1579962369129100

andrewballantyne · 2020-01-25T19:38:04Z

/hold cancel
/retest

Looks like it's good to go again.

openshift-bot · 2020-01-25T19:49:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T20:02:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-25T20:15:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2020

openshift-ci-robot requested review from abhi-kn and debsmita1 January 23, 2020 00:10

openshift-ci-robot added the component/dev-console Related to dev-console label Jan 23, 2020

karthikjeeyar force-pushed the operator-grouping branch from ffcffe1 to b979071 Compare January 23, 2020 08:10

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/shared Related to console-shared and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2020

karthikjeeyar force-pushed the operator-grouping branch 2 times, most recently from 605d71d to bca5a1e Compare January 23, 2020 08:38

openshift-ci-robot changed the title ~~WIP: feat(operator-grouping): add operator grouping in topology~~ feat(operator-grouping): add operator grouping in topology Jan 23, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2020

karthikjeeyar force-pushed the operator-grouping branch from bca5a1e to ebfca66 Compare January 23, 2020 09:27

openshift-ci-robot assigned christianvogt Jan 23, 2020

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2020

divyanshiGupta reviewed Jan 23, 2020

View reviewed changes

karthikjeeyar force-pushed the operator-grouping branch from ebfca66 to 2722570 Compare January 23, 2020 11:05

jeff-phillips-18 reviewed Jan 23, 2020

View reviewed changes

karthikjeeyar force-pushed the operator-grouping branch from 2722570 to b156245 Compare January 23, 2020 13:15

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2020

karthikjeeyar commented Jan 23, 2020

View reviewed changes

jeff-phillips-18 approved these changes Jan 23, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Jan 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020

karthikjeeyar force-pushed the operator-grouping branch from eebf39d to 7646978 Compare January 25, 2020 07:30

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020

karthikjeeyar force-pushed the operator-grouping branch from 7646978 to 74b0a95 Compare January 25, 2020 07:33

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020

feat(operator-grouping): add operator grouping in topology

9ae363b

karthikjeeyar force-pushed the operator-grouping branch from 74b0a95 to 9ae363b Compare January 25, 2020 07:40

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2020

openshift-merge-robot merged commit ec542d0 into openshift:master Jan 25, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

feat(operator-grouping): add operator grouping in topology #4048

feat(operator-grouping): add operator grouping in topology #4048

Uh oh!

Conversation

karthikjeeyar commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karthikjeeyar commented Jan 23, 2020

Uh oh!

karthikjeeyar commented Jan 23, 2020

Uh oh!

karthikjeeyar commented Jan 23, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karthikjeeyar Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewballantyne commented Jan 25, 2020

Uh oh!

andrewballantyne commented Jan 25, 2020

Uh oh!

andrewballantyne commented Jan 25, 2020

Uh oh!

openshift-ci-robot commented Jan 25, 2020

Uh oh!

karthikjeeyar commented Jan 25, 2020

Uh oh!

andrewballantyne commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

karthikjeeyar commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

andrewballantyne commented Jan 25, 2020

Uh oh!

andrewballantyne commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

openshift-bot commented Jan 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

karthikjeeyar commented Jan 23, 2020 •

edited

Loading

karthikjeeyar Jan 23, 2020 •

edited

Loading