Skip to content

[release-4.3] Bug 1794925: correctly show schema information for all core resources #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 14, 2020
Merged

[release-4.3] Bug 1794925: correctly show schema information for all core resources #4067

openshift-merge-robot merged 1 commit into from
Feb 14, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 25, 2020

This is an automated cherry-pick of #4062

/assign spadgett

@spadgett
Bug 1794754: correctly show schema information for all core resources
d9faec9 
Core k8s resources that didn't have a static model defined were missing
schema information in the Explore page and YAML editor sidebar. This is
because we were using API group `core` internally and incorrectly using
the internal group when looking up the resource in the OpenAPI doc.

This changes console to not use `core` in when creating models from
discovery.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1794754, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1794754 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1794754: correctly show schema information for all core resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality labels Jan 25, 2020
spadgett
spadgett approved these changes Jan 25, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2020
@spadgett spadgett changed the title [release-4.3] Bug 1794754: correctly show schema information for all core resources [release-4.3] Bug 1794925: correctly show schema information for all core resources Jan 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1794925, which is invalid:

  • expected dependent Bugzilla bug 1794754 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1794925: correctly show schema information for all core resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

spadgett commented Feb 7, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2020

@spadgett: This pull request references Bugzilla bug 1794925, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.3.z milestone Feb 7, 2020
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3bc0fba into openshift:release-4.3 Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1794925 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1794925: correctly show schema information for all core resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
@openshift-merge-robot
Merge pull request openshift#4067 from openshift-cherrypick-robot/che…
424b9c2 
…rry-pick-4062-to-release-4.3

[release-4.3] Bug 1794925: correctly show schema information for all core resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3.z

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @spadgett @mfojtik @openshift-merge-robot