Bug 1798357: Bump formik

[divyanshiGupta]

Jira Issue - https://issues.redhat.com/browse/ODC-2853

After formik upgrade to 2.0.1-rc.5 this error jaredpalmer/formik#1678 started to pop on forms where it is needed to populate the form fields with existing values and an existing event handler is used inside useEffect to achieve this.

For example dev-console edit flows (In deploy image internal registry edit flow imageStreamNamespace is already set and onDropdownChange is called to fill the other fields and dispatch desired actions according to the namespace).

formik upgrade is needed for dev-console edit flows:

• Add edit application functionality from topology #3788
• Bug 1808280: Add edit application feature for apps created using deploy image flow #3931

Solution:
Upgrade to 2.1.2
It gives this error -

To resolve this we need to upgrade @types/react and it gives another lot of errors on upgrade.

Upgrade to 2.0.3
It solves the formik issue jaredpalmer/formik#1678 and does not give the above mentioned type error and hence no need of upgrading @types/react.

@rohitkrai03 Which approach seems better? I think upgrading to 2.0.3 will be better for the time being

cc: @christianvogt

[divyanshiGupta]

/retest

[divyanshiGupta]

/retest

[spadgett]

ERROR in /go/src/github.com/openshift/console/frontend/node_modules/formik/dist/Form.d.ts
(3,150): Type '"hidden" | "dir" | "slot" | "style" | "title" | "color" | "key" | "children" | "prefix" | "acceptCharset" | "action" | "autoComplete" | "encType" | "method" | "name" | "noValidate" | ... 246 more ... | "translate"' does not satisfy the constraint '"hidden" | "dir" | "slot" | "style" | "title" | "color" | "key" | "ref" | "children" | "prefix" | "acceptCharset" | "action" | "autoComplete" | "encType" | "method" | "name" | "noValidate" | ... 246 more ... | "onTransitionEndCapture"'.
  Type '"translate"' is not assignable to type '"hidden" | "dir" | "slot" | "style" | "title" | "color" | "key" | "ref" | "children" | "prefix" | "acceptCharset" | "action" | "autoComplete" | "encType" | "method" | "name" | "noValidate" | ... 246 more ... | "onTransitionEndCapture"'.

[divyanshiGupta]

Yes already mentioned the error in the description. Shouldnt have retested because obviously the tests will fail.

[rohitkrai03]

@divyanshiGupta I think we can go ahead with upgrade to 2.0.3 for now and later upgrade to latest with all the required changes.

[rohitkrai03]

/lgtm

[andrewballantyne]

/kind bug

@divyanshiGupta looks like you have a test break around Formik components.

[divyanshiGupta]

@andrewballantyne fixed the test.

[andrewballantyne]

@divyanshiGupta Awesome, you'll need to get Christian or someone from Admin to approve it as it reached outside of our teams packages for me to approve.

[divyanshiGupta]

/assign @christianvogt

[divyanshiGupta]

@andrewballantyne you can add lgtm as it got removed because of the test fix.

[rohitkrai03]

/lgtm

[christianvogt]

@divyanshiGupta why is it we need to use useFormikContext here but we still use useField elsewhere like here:
https://github.com/openshift/console/blob/master/frontend/packages/dev-console/src/components/import/git/SourceSecretSelector.tsx#L12

[divyanshiGupta]

@christianvogt after upgrade it was throwing error on line 18,27,37 and 46 that the defaultRequestUnit does not exist on type string, I tried to do a bunch of things but the error wont go, then I tried to use the same values from useFormikContext and the error was gone.

Then I went through the implementation and they have changed the implementation of getFieldProps (used inside useField to get the field values) a bit from 2.0.1rc5 to 2.0.3. Now in 2.0.3 its enforced that we need to pass an object to useField for field types such as checkbox to get the desired data, but for other field types such TextInput passing a string of field name is sufficient. For full context you will have to go through the above 2 links I posted.

I missed to update the ToggleableFieldBase though, will do it. But I think for our use case here its okay to use useFormikContext in ResourceLimitSection since its not a FormikField and useField, if you see the implementation makes more sense when used in a FormikField.

[divyanshiGupta]

Updated the ToggleableFieldBase according to the changes made in useField in 2.0.3.

[christianvogt]

fyi @jtomasek

[christianvogt]

/lgtm
/approve

[christianvogt]

@divyanshiGupta please add a bz

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@divyanshiGupta: This pull request references Bugzilla bug 1798357, which is invalid:

• expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1798357: Bump formik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[divyanshiGupta]

/bugzilla refresh

[openshift-ci-robot]

@divyanshiGupta: This pull request references Bugzilla bug 1798357, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@divyanshiGupta: All pull requests linked via external trackers have merged. Bugzilla bug 1798357 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1798357: Bump formik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.