Bug 1797567: add unit test for custome hook usePodScalingAccessStatus #4133

sahil143 · 2020-01-31T09:02:14Z

fixes: https://issues.redhat.com/browse/ODC-2669
This PR adds unit test for custom hook usePodScalingAccessStatus which was missing in PR #3746

openshift-ci-robot · 2020-02-03T12:28:34Z

@sahil143: This pull request references Bugzilla bug 1797567, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1797567: add unit test for custome hook usePodScalingAccessStatus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2020-02-03T12:48:03Z

frontend/packages/console-shared/src/utils/pod-ring-utils.ts

This is odd for client code to have to provide this isn't it?
Seems like you are just doing this change so that you can unit test the code.
Why not mock checkPodEditAccess instead?

andrewballantyne · 2020-02-03T14:25:00Z

/kind bug

initial test for hooks Initial commit add unit tests for custom hook experimenting update the tests remove apicallfn dependecy remove console.log do lint

christianvogt · 2020-02-18T20:41:41Z

frontend/packages/console-shared/src/utils/__tests__/pod-utils.spec.ts

+      .catch(() => {});
+  });
+
+  it('should have access false if check Access return allowed false', () => {


async test missing done callback

christianvogt · 2020-02-20T02:24:19Z

/retest

spadgett · 2020-02-20T15:16:17Z

/bugzilla refresh

openshift-ci-robot · 2020-02-20T15:16:21Z

@spadgett: This pull request references Bugzilla bug 1797567, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2020-02-20T16:25:42Z

/retest

openshift-bot · 2020-02-20T21:17:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-20T22:55:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-20T23:09:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-20T23:22:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T12:41:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T12:53:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T14:11:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T15:43:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-02-21T16:24:26Z

/hold
for test fix #4411

spadgett · 2020-02-21T18:12:12Z

/hold cancel
/retest

openshift-bot · 2020-02-21T18:19:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

andrewballantyne · 2020-02-21T19:44:24Z

/retest

Failed on the test right after the one we fixed in #4411 -- maybe a flake... going to try again.

openshift-bot · 2020-02-21T20:31:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T23:33:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T23:59:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T03:01:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T04:19:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T06:03:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T06:16:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T07:34:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T07:47:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T08:52:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T09:05:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T11:54:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-22T12:07:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-22T13:22:50Z

@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1797567 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1797567: add unit test for custome hook usePodScalingAccessStatus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2020

sahil143 changed the title ~~add unit test for custome hook usePodScalingAccessStatus~~ [WIP] add unit test for custome hook usePodScalingAccessStatus Jan 31, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2020

openshift-ci-robot requested review from abhi-kn and spadgett January 31, 2020 09:02

openshift-ci-robot added component/dev-console Related to dev-console component/shared Related to console-shared labels Jan 31, 2020

sahil143 changed the title ~~[WIP] add unit test for custome hook usePodScalingAccessStatus~~ add unit test for custome hook usePodScalingAccessStatus Jan 31, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2020

sahil143 changed the title ~~add unit test for custome hook usePodScalingAccessStatus~~ Bug 1797567: add unit test for custome hook usePodScalingAccessStatus Feb 3, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020

christianvogt reviewed Feb 3, 2020

View reviewed changes

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 3, 2020

sahil143 force-pushed the pr-3746-tests branch from 110f033 to 809f14a Compare February 18, 2020 20:05

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2020

sahil143 force-pushed the pr-3746-tests branch from 809f14a to 9e209ed Compare February 18, 2020 20:15

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2020

sahil143 force-pushed the pr-3746-tests branch from 9e209ed to f10ee7a Compare February 18, 2020 20:21

add unit test for custome hook usePodScalingAccessStatus

dbb258a

initial test for hooks Initial commit add unit tests for custom hook experimenting update the tests remove apicallfn dependecy remove console.log do lint

sahil143 force-pushed the pr-3746-tests branch from f10ee7a to dbb258a Compare February 18, 2020 20:23

christianvogt reviewed Feb 18, 2020

View reviewed changes

make tests async

ff73bac

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 20, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020

spadgett added this to the v4.5 milestone Feb 22, 2020

openshift-merge-robot merged commit f31167a into openshift:master Feb 22, 2020

Bug 1797567: add unit test for custome hook usePodScalingAccessStatus #4133

Bug 1797567: add unit test for custome hook usePodScalingAccessStatus #4133

Uh oh!

Conversation

sahil143 commented Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 3, 2020

Uh oh!

christianvogt Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

andrewballantyne commented Feb 3, 2020

Uh oh!

christianvogt Feb 18, 2020

Choose a reason for hiding this comment

Uh oh!

christianvogt commented Feb 20, 2020

Uh oh!

spadgett commented Feb 20, 2020

Uh oh!

openshift-ci-robot commented Feb 20, 2020

Uh oh!

christianvogt commented Feb 20, 2020

Uh oh!

openshift-bot commented Feb 20, 2020

Uh oh!

openshift-bot commented Feb 20, 2020

Uh oh!

openshift-bot commented Feb 20, 2020

Uh oh!

openshift-bot commented Feb 20, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

spadgett commented Feb 21, 2020

Uh oh!

spadgett commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

andrewballantyne commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-bot commented Feb 22, 2020

Uh oh!

openshift-ci-robot commented Feb 22, 2020

Uh oh!

Reviewers

Assignees

Labels

sahil143 commented Jan 31, 2020 •

edited

Loading