Bug 1797974: fix overview status #4171
Conversation
openshift-ci-robot
added
the
size/XS
|
@suomiy please review |
openshift-ci-robot
added
component/kubevirt
yaacov
changed the title
|
@yaacov: This pull request references Bugzilla bug 1797974, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/test analyze |
There was a problem hiding this comment.
we shouldn't have a different approach for vm row and the details page.
Also we should try to infer the status from all the connected resources we are aware of. There might be some bug or wrong implementation in getVMStatus. We should be consistent for all statuses.
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@yaacov: This pull request references Bugzilla bug 1797974, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/S
yaacov
force-pushed
the
fix-overview-status
branch
from
fdc0c3e to
d5cf38e
Compare
yaacov
force-pushed
the
fix-overview-status
branch
from
d5cf38e to
14b72b2
Compare
|
@suomiy please re-review |
| }) => { | ||
| const vm = kindObj === VirtualMachineModel && isVM(objProp) ? objProp : vmProp; | ||
| const vmi = kindObj === VirtualMachineInstanceModel && isVMI(objProp) ? objProp : vmiProp; | ||
| const vm = kindObj === VirtualMachineModel && isVM(objProp) ? objProp : isVM(vmProp) && vmProp; |
There was a problem hiding this comment.
how come? The types in VMTabProps should always corespond no? How does this help?
Are the objects different when you look at them in debug, and why are they different?
There was a problem hiding this comment.
how come? The types in VMTabProps should always corespond no?
Are the objects different when you look at them in debug, and why are they different?
If we do not find an object with matching type. vmProp is an empty object when no matching vm is found, since we check if (vm) ... we get a false true becase {} is true.
How does this help?
So we need to check vmProp (and vmiProp) for empty objects.
There was a problem hiding this comment.
ah I see, it is that weird behaviour when firehose gives empty object. Could we at least pass null instead of false when that happens?
|
/test analyze |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
spadgett
changed the title
|
@yaacov: All pull requests linked via external trackers have merged. Bugzilla bug 1797974 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
In #3949 I introduced an error in status rendering.
This PR fixes the status rendering in vm/vmi overview.
Screenshots
before:
after:
