Bug 1802600: Add unpause VM tests #4194

pcbailey · 2020-02-05T02:38:03Z

This PR adds tests for the unpause VM functionality added in #3985.

openshift-ci-robot · 2020-02-13T14:14:46Z

@pcbailey: This pull request references Bugzilla bug 1802600, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1802600: Add unpause VM tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhrazdil · 2020-02-14T15:35:34Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.actions.scenario.ts

Is the pause action immediate? Shouldn't we wait for Paused status?

rhrazdil · 2020-02-14T15:38:05Z

frontend/packages/kubevirt-plugin/integration-tests/views/editStatusView.ts

Maybe better to call it unpauseButton?

rhrazdil · 2020-02-14T15:38:34Z

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts

I think this deserves a docstring. I don't understand why opening a modal window unpauses the VM

rhrazdil · 2020-02-20T12:44:29Z

/bugzilla refresh

openshift-ci-robot · 2020-02-20T12:44:32Z

@rhrazdil: This pull request references Bugzilla bug 1802600, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhrazdil · 2020-02-20T12:47:02Z

Verified the tests, I'm okay with current implementation.
/lgtm

pcbailey · 2020-02-21T00:41:55Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-02-21T00:41:56Z

@pcbailey: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pcbailey · 2020-02-21T00:42:45Z

/bugzilla refresh

openshift-ci-robot · 2020-02-21T00:42:49Z

@pcbailey: This pull request references Bugzilla bug 1802600, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-02-21T11:23:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T13:45:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T15:32:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-02-21T16:23:14Z

/hold
for test fix #4411

spadgett · 2020-02-21T18:12:20Z

/hold cancel
/retest

openshift-bot · 2020-02-21T18:32:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T21:37:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T21:49:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-21T22:28:50Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rhrazdil · 2020-02-27T14:19:34Z

/lgtm

openshift-ci-robot · 2020-02-27T14:23:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [rhrazdil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-27T16:29:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-27T16:42:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-27T17:47:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-27T21:04:56Z

@pcbailey: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	d22188008db55bdbd0873a2adf7e00bb1b864aa7	link	`/test verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-02-27T21:18:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-27T21:41:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-27T22:12:19Z

@pcbailey: All pull requests linked via external trackers have merged. Bugzilla bug 1802600 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1802600: Add unpause VM tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-02-27T22:12:29Z

@pcbailey: #4194 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
M	frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
error: Failed to merge in the changes.
Patch failed at 0001 Add unpause VM tests

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jelkosz · 2020-02-28T11:11:42Z

lets see if the cherry pick bot took the latest version:
/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-02-28T11:11:47Z

@jelkosz: #4194 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
M	frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/views/virtualMachine.view.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/vm.overview.scenario.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/utils/utils.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/consts.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/models/kubevirtDetailView.ts
error: Failed to merge in the changes.
Patch failed at 0001 Add unpause VM tests

Details

In response to this:

lets see if the cherry pick bot took the latest version:
/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jelkosz · 2020-02-28T11:12:38Z

it did :(
@pcbailey please backport manually

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Feb 5, 2020

openshift-ci-robot requested review from jelkosz and rawagner February 5, 2020 02:39

pcbailey force-pushed the unpause-vm-tests branch from d91e639 to d221880 Compare February 13, 2020 14:03

pcbailey changed the title ~~WIP: Add unpause VM tests~~ Add unpause VM tests Feb 13, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2020

pcbailey changed the title ~~Add unpause VM tests~~ Bug 1802600: Add unpause VM tests Feb 13, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 13, 2020

rhrazdil suggested changes Feb 14, 2020

View reviewed changes

openshift-ci-robot assigned rhrazdil Feb 20, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 20, 2020

spadgett added this to the v4.5 milestone Feb 20, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2020

Add unpause VM tests

252d2f4

pcbailey force-pushed the unpause-vm-tests branch from d221880 to 252d2f4 Compare February 27, 2020 14:06

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020

openshift-merge-robot merged commit 458ca23 into openshift:master Feb 27, 2020

pcbailey mentioned this pull request Feb 28, 2020

Bug 1805544: Add unpause VM tests #4551

Merged

pcbailey deleted the unpause-vm-tests branch October 26, 2022 12:32

Bug 1802600: Add unpause VM tests #4194

Bug 1802600: Add unpause VM tests #4194

Uh oh!

Conversation

pcbailey commented Feb 5, 2020

Uh oh!

openshift-ci-robot commented Feb 13, 2020

Uh oh!

rhrazdil Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

rhrazdil Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

rhrazdil Feb 14, 2020

Choose a reason for hiding this comment

Uh oh!

rhrazdil commented Feb 20, 2020

Uh oh!

openshift-ci-robot commented Feb 20, 2020

Uh oh!

rhrazdil commented Feb 20, 2020

Uh oh!

pcbailey commented Feb 21, 2020

Uh oh!

openshift-cherrypick-robot commented Feb 21, 2020

Uh oh!

pcbailey commented Feb 21, 2020

Uh oh!

openshift-ci-robot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

spadgett commented Feb 21, 2020

Uh oh!

spadgett commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

openshift-bot commented Feb 21, 2020

Uh oh!

rhrazdil commented Feb 27, 2020

Uh oh!

openshift-ci-robot commented Feb 27, 2020

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-ci-robot commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-bot commented Feb 27, 2020

Uh oh!

openshift-ci-robot commented Feb 27, 2020

Uh oh!

openshift-cherrypick-robot commented Feb 27, 2020

Uh oh!

jelkosz commented Feb 28, 2020

Uh oh!

openshift-cherrypick-robot commented Feb 28, 2020

Uh oh!

jelkosz commented Feb 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

openshift-ci-robot commented Feb 27, 2020 •

edited

Loading