Skip to content

Bug 1801212: Fix to show error message when URL validation fails #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeff-phillips-18 wants to merge 0 commits into from
Closed

Bug 1801212: Fix to show error message when URL validation fails #4268

jeff-phillips-18 wants to merge 0 commits into from

Conversation

@jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Feb 10, 2020

Fixes:
https://issues.redhat.com/browse/ODC-2944

Analysis / Root cause:
When validation of the URL fails, the validation error and validation state were not being passed along to the InputText component.

Solution Description:
Pass the validation error and validation state to the InputText component

** Sample Screen Shots **
image

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2020

@jeff-phillips-18: This pull request references Bugzilla bug 1801212, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1801212: Fix to show error message when URL validation fails

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console component/shared Related to console-shared labels Feb 10, 2020
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Feb 10, 2020

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2020
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2020
@christianvogt
Copy link
Contributor

christianvogt commented Feb 11, 2020

/retest

christianvogt
christianvogt reviewed Feb 11, 2020
View reviewed changes
frontend/packages/console-shared/src/components/formik-fields/field-types.ts Outdated
Copy link
Contributor

@christianvogt christianvogt Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be on InputFieldProps?
Not a big fan of tri-state booleans. Maybe use PatternFly's ValidatedOptions, or at least add a comment.

Copy link
Member Author

@jeff-phillips-18 jeff-phillips-18 Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2020
@andrewballantyne andrewballantyne mentioned this pull request Feb 12, 2020
Merged
rohitkrai03
rohitkrai03 suggested changes Feb 12, 2020
View reviewed changes
frontend/packages/dev-console/src/components/import/import-types.ts Outdated
Copy link
Contributor

@rohitkrai03 rohitkrai03 Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still boolean? I think it should also be

Suggested change
isUrlValidated?: boolean;
isUrlValidated?: ValidatedOptions;

frontend/packages/dev-console/src/components/import/git/GitSection.tsx Outdated
Copy link
Contributor

@rohitkrai03 rohitkrai03 Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename this from isUrlValidated to something else since its not a boolean anymore. Something like validationStatus?

@jeff-phillips-18
Copy link
Member Author

jeff-phillips-18 commented Feb 18, 2020

Waiting on merge of #4187 to refactor

@jeff-phillips-18
Copy link
Member Author

jeff-phillips-18 commented Feb 19, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 19, 2020

@jeff-phillips-18: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@debsmita1 debsmita1 Awaiting requested review from debsmita1

@zherman0 zherman0 Awaiting requested review from zherman0

2 more reviewers

@christianvogt christianvogt christianvogt left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/shared Related to console-shared kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeff-phillips-18 @openshift-ci-robot @andrewballantyne @christianvogt @openshift-cherrypick-robot @rohitkrai03