Skip to content

Bug 1804827: Improve monitoring dashboards table layout #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 20, 2020
Merged

Bug 1804827: Improve monitoring dashboards table layout #4371

openshift-merge-robot merged 1 commit into from
Feb 20, 2020

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Feb 19, 2020

  • Make label columns wider to avoid wrapping
  • Order label columns first
  • Humanize short numbers
  • Use horizontal scrolling even at mobile to reduce table height

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804827

/assign @rhamilto

Screen Shot 2020-02-19 at 11 21 06 AM

Screen Shot 2020-02-19 at 12 31 06 PM

@spadgett
Bug 1804827: Improve monitoring dashboards table layout
aae8ba5 
* Make label columns wider to avoid wrapping
* Order label columns first
* Humanize `short` numbers
* Use horizontal scrolling even at mobile to reduce table height

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1804827
@spadgett spadgett added this to the v4.5 milestone Feb 19, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020

@spadgett: This pull request references Bugzilla bug 1804827, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1804827: Improve monitoring dashboards table layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Feb 19, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@spadgett
Copy link
Member Author

spadgett commented Feb 19, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 19, 2020

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto
rhamilto approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4765976 into openshift:master Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1804827 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1804827: Improve monitoring dashboards table layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 20, 2020

@spadgett: new pull request created: #4385

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett deleted the table-styles branch February 20, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.5

Development

Successfully merging this pull request may close these issues.

6 participants

@spadgett @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @rhamilto @openshift-merge-robot