Bug 1801212: Fix to show error message when URL validation fails #4376
Conversation
openshift-ci-robot
added
the
kind/bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1801212, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1801212, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
component/core
|
/retest |
1 similar comment
|
/retest |
|
Tested the git import flow successfully. |
|
Must have been a flake. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherrypick release-4.4 |
|
@jeff-phillips-18: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jeff-phillips-18: new pull request created: #4392 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Fixes:
https://issues.redhat.com/browse/ODC-2944
Analysis / Root cause:
When validation of the URL fails, the validation error and validation state were not being passed along to the InputText component.
Solution Description:
Pass the validation error and validation state to the InputText component.
Fix the CSS to correctly show the validation icon within the InputText
Remove icons from the help text
** Sample Screen Shots **
Browser conformance:
cc @openshift/team-devconsole-ux
/kind bug