Skip to content

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image #4403

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 20, 2020

This is an automated cherry-pick of #4187

/assign christianvogt

@sahil143
remove search button and search status/result for deploy image
02b2cf9 
add validated text

show field required when searchTerm is empty

create scss file  for image search component,  use patternfly validatedOption enum

add data-test-id to ImageSearch component

add classes for success help text

s

remove styles

removed funtional test because Input search button is removed and no longer used

remove $

fix functional tests

show inline error for ImageStream

add error

refactor

reorder Imports
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 20, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1797702, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1797702 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1797702: remove search button and search status/result for deploy image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console component/shared Related to console-shared labels Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign jhadvig
You can assign the PR to them by writing /assign @jhadvig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 20, 2020

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/backend 02b2cf9 link /test backend
ci/prow/analyze 02b2cf9 link /test analyze
ci/prow/frontend 02b2cf9 link /test frontend
ci/prow/images 02b2cf9 link /test images
ci/prow/e2e-gcp-console 02b2cf9 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@christianvogt
Copy link
Contributor

christianvogt commented Feb 21, 2020

/retitle [release-4.4] Bug 1805440: remove search button and search status/result for deploy image

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1797702: remove search button and search status/result for deploy image [release-4.4] Bug 1805440: remove search button and search status/result for deploy image Feb 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 21, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1805440, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.4] Bug 1805440: remove search button and search status/result for deploy image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

christianvogt commented Feb 21, 2020

/hold
possible e2e failure due #4187

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Feb 21, 2020

Needs the test solution from #4187 before removing the hold.

@sahil143
Copy link
Contributor

sahil143 commented Feb 24, 2020

/close

raised another PR #4433 with functional test fix

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2020

@sahil143: Closed this PR.

Details

In response to this:

/close

raised another PR #4433 with functional test fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@christianvogt christianvogt

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console component/shared Related to console-shared do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @openshift-ci-robot @christianvogt @andrewballantyne @sahil143