Skip to content

[release-4.4] Bug 1806641: Changes to monitoring dashboard dropdown behavior #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 25, 2020
Merged

[release-4.4] Bug 1806641: Changes to monitoring dashboard dropdown behavior #4443

openshift-merge-robot merged 1 commit into from
Feb 25, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 24, 2020

This is an automated cherry-pick of #4399

/assign sg00dwin

@sg00dwin
Changes to monitoring dashboard dropdown behavior - Enable time range…
bced3b3 
… and interval to wrap beneath <h1> - Remove set width from dropdowns so that long selected item text isn't agressively truncated. - and enable truncation at mobile widths
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1805835, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected Bugzilla bug 1805835 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1805835: Changes to monitoring dashboard dropdown behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Feb 24, 2020
@sg00dwin sg00dwin changed the title [release-4.4] Bug 1805835: Changes to monitoring dashboard dropdown behavior [release-4.4] Bug 1806641: Changes to monitoring dashboard dropdown behavior Feb 24, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806641, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

[release-4.4] Bug 1806641: Changes to monitoring dashboard dropdown behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@spadgett spadgett added this to the v4.4 milestone Feb 24, 2020
@spadgett spadgett added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ab6c992 into openshift:release-4.4 Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1806641 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1806641: Changes to monitoring dashboard dropdown behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
@openshift-merge-robot
Merge pull request openshift#4443 from openshift-cherrypick-robot/che…
98a67f0 
…rry-pick-4399-to-release-4.4

[release-4.4] Bug 1806641: Changes to monitoring dashboard dropdown behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@spadgett spadgett

@sg00dwin sg00dwin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @openshift-bot @spadgett @sg00dwin @openshift-merge-robot