KNIP-525: Add an Environment tab for Virtual Machines

[irosenzw]

• Add an Environment tab for virtual machines
• The user can now add configmaps, secrets and service accounts
  to VMs as disks but has to mount them manually.
  (not all images support CloudInit)

Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

[yaacov]

why not getRandomChars(16) ? what am I missing ?

[irosenzw]

because the limit is 10.
if you give it 16 you will get 10 eventually.

[yaacov]

kubevirt-create-nic-modal__buttons ?

[irosenzw]

/retest

[rawagner]

we can further simplify and merge types ConfigMapListKind, SecretListKind and ServiceAccountListKind using generics

export type ListKind<R extends K8sResourceCommon> = K8sResourceCommon & {
  items: R[];
}

and the usage for example here https://github.com/openshift/console/blob/5bb0ed6137a5d661ab98118cee25e1da444cb8f1/frontend/packages/kubevirt-plugin/src/components/vms/vm-environment/selectors.ts#L63 would be

): ListKind<ConfigMapKind | SecretKind | ServiceAccountKind> => {

[rawagner]

you shoud define new type - something like

type EnvDisk = [string, EnvVarSource, number];

Suggested change

	export const getSerial = (ed): string => ed[0];
	export const getSerial = (ed: EnvDisk): string => ed[0];

and use it everywhere. Makes the code a lot more readable

[rawagner]

Suggested change

	export const getSource = (ed): EnvVarSource => ed[1];
	export const getSource = (ed: EnvDisk): EnvVarSource => ed[1];

[rawagner]

Suggested change

	export const getSourceKind = (envDisk: (string | object | number)[]): string => {
	export const getSourceKind = (envDisk: EnvDisk): string => {

[rawagner]

Suggested change

	envDisk1: (string | object | number)[],
	envDisk1: EnvDisk,

[rawagner]

Suggested change

	const updateEnvDisks = (newEnvDisks) => {
	const updateEnvDisks = (newEnvDisks: NameValuePairs) => {

[rawagner]

Suggested change

	export const setNewSourceDisk = (diskName: string, serial: string, diskBus: string) => {
	export const setNewSourceDisk = (diskName: string, serial: string, diskBus: string): V1Disk => {

[rawagner]

no need to specify V1Volume as setNewSourceVolume has correct signature

Suggested change

	const newVolume: V1Volume = setNewSourceVolume(
	const newVolume = setNewSourceVolume(

[rawagner]

Suggested change

	let newSourcesDisks = [];
	let newSourcesDisks: V1Disk[] = [];

[rawagner]

Suggested change

	let newSourcesVolumes = [];
	let newSourcesVolumes: V1Volume[] = [];

[rawagner]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment