-
Notifications
You must be signed in to change notification settings - Fork 667
update api group for node-maintenance operator #4967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update api group for node-maintenance operator #4967
Conversation
|
Hi @ksimon1. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please notice that in order to go GA this should be at least v1beta1, maybe it's worth to address both in a single PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me. We just have to wait if this change will get into node maintenance operator
Signed-off-by: Karel Simon <ksimon@redhat.com>
191e9a7 to
de6966c
Compare
|
/hold until dependent PR merges kubevirt/node-maintenance-operator#73 |
|
@jtomasek nmo PR is merged, can you please merge this one as well? |
|
/ok-to-test |
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtomasek, ksimon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/hold cancel |
Node-maintenance operator is moving into its own api group.
kubevirt/node-maintenance-operator#73
Signed-off-by: Karel Simon ksimon@redhat.com