Add Remove Trigger

[andrewballantyne]

Fixes:
https://issues.redhat.com/browse/ODC-3349

Analysis / Root cause:
Need a way to remove the triggers we add.

Solution Description:
Remove trigger modal.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Empty state seems lame... Probably should find a way not to show the modal... but it requires fetching to find out that information... 🤔

I added a minor gap slightly smaller than a single line message to hack our way around PatternFly and their dropdown/modal issue:

Selected and ready to remove:

Unit test coverage report:

• Likely some components that can be tested here

Test setup:

• Install Pipelines Operator
• Have a trigger installed
• Remove

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[divyanshiGupta]

@andrewballantyne apart from your last commit, other commits are reorganizing/refactoring code or they add or change any functionalities?

[andrewballantyne]

@andrewballantyne apart from your last commit, other commits are reorganizing/refactoring code or they add or change any functionalities?

Apologizes, been reviewing and haven't had a chance to refactor (actually doing that right now).

Everything before the last commit is stacking PRs. The last commit is the only one that matters for the content of this PR.

[andrewballantyne]

@divyanshiGupta I have made this PR a tiny bit smaller 🙂

[divyanshiGupta]

@divyanshiGupta I have made this PR a tiny bit smaller slightly_smiling_face

Its like you removed 80% of the code. 😜

[divyanshiGupta]

@andrewballantyne the code looks good to me. Need to try to it locally once. Also please resolve the conflicts.

[karthikjeeyar]

@andrewballantyne verified removing triggers, it works fine.

I agree with you, instead of empty state we should not show the remove tirgger option to the pipeline which does not have TT and EL. May be we could do that in a followup PR.

[andrewballantyne]

I agree with you, instead of empty state we should not show the remove tirgger option to the pipeline which does not have TT and EL. May be we could do that in a followup PR.

Absolutely. Unless there is a critical issue, no additions are happening on the current Pipeline PRs. We'll cover it after FF. I'll log a bug to track (https://issues.redhat.com/browse/ODC-3589).

[divyanshiGupta]

@andrewballantyne the code looks good to me. Need to try to it locally once. Also please resolve the conflicts.

Tried it locally, works fine. Will add lgtm once the remaining comments are resolved.

[karthikjeeyar]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[divyanshiGupta]

Looks good.
/lgtm

[andrewballantyne]

/retest

[andrewballantyne]

error: could not run steps: step test-bin failed: could not wait for build: could not create watcher for build test-bin: the server is currently unable to handle the request (get builds.build.openshift.io)

That's a first.

/test frontend

[andrewballantyne]

/retest

[andrewballantyne]

/retest

[andrewballantyne]

/kind feature