Update StartNodeMaintenanceModal to use useK8sWatchResource hook #5087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/metal3
jtomasek
force-pushed
the
start-maintenance-update
branch
from
b7084ed to
8fcbeea
Compare
Author
|
/assign @rawagner |
rawagner
suggested changes
Apr 17, 2020
frontend/packages/metal3-plugin/src/components/modals/StartNodeMaintenanceModal.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
👍 nice |
jtomasek
force-pushed
the
start-maintenance-update
branch
from
279c8b5 to
47b19c1
Compare
Instead of Firehose wrapper. Remove unused create-modal-resource-launcher module.
jtomasek
force-pushed
the
start-maintenance-update
branch
from
47b19c1 to
c626718
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jtomasek, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of Firehose wrapper