Skip to content

Monitoring: Add docs link for regular expressions on the silence form #5089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 18, 2020
Merged

Monitoring: Add docs link for regular expressions on the silence form #5089

openshift-merge-robot merged 1 commit into from
Apr 18, 2020

Conversation

@kyoto
Copy link
Member

@kyoto kyoto commented Apr 17, 2020

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Apr 17, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@kyoto
Copy link
Member Author

kyoto commented Apr 17, 2020

/retest

spadgett
spadgett approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

dtaylor113
dtaylor113 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Apr 17, 2020

/hold
for #5100

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@spadgett
Copy link
Member

spadgett commented Apr 17, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit f6c6aa3 into openshift:master Apr 18, 2020
@kyoto kyoto deleted the monitoring-silenced-regex-doc-link branch April 18, 2020 02:26
@spadgett spadgett added this to the v4.5 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

+1 more reviewer

@dtaylor113 dtaylor113 dtaylor113 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.5

Development

Successfully merging this pull request may close these issues.

6 participants

@kyoto @openshift-bot @openshift-ci-robot @spadgett @dtaylor113 @openshift-merge-robot