include helm and pipelines in +Add page #5099
Conversation
openshift-ci-robot
added
component/dev-console
There was a problem hiding this comment.
This is a UX approved icon?
There was a problem hiding this comment.
We're working on getting another SVG, but it's very similar yes :) It's the b&w version of the operator logo
There was a problem hiding this comment.
| icon={typeof icon === 'object' ? icon : undefined} | |
| icon={React.isValidElement(icon) ? icon : undefined} |
Pretty sure this is the check you want.
serenamarie125
left a comment
serenamarie125
left a comment
There was a problem hiding this comment.
LGTM @christianvogt ! Thanks for doing this :) Approved by UX
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 participants
Analysis / Root cause:
Request to include operator backed, helm and pipeline cards in +Add page for discovery.
Solution Description:
Use extension mechanism to include new cards in the +Add page.
Updated event sources icon as well
Screen shots / Gifs for design review:
cc @openshift/team-devconsole-ux @siamaksade
Test setup:
Helm card will always be present.
Pipeline card will only appear if pipeline operator is installed.
Browser conformance: