Bug 1878016: Add documentation to describe configuring multiple helm chart repos #6324

akashshinde · 2020-08-13T03:35:37Z

This PR adds documentation for the feature introduced in #5933

akashshinde · 2020-08-13T07:45:10Z

/test e2e-gcp-console

jhadvig

Adding couple of questions. Not entirely familiar with Helm so need to clear this out.

docs/helm/configure-3rdparty-repos-access.md

jhadvig · 2020-08-17T14:47:17Z

docs/helm/endpoints_api.md

Shouldn't here be a 404 as well ?

might be, but that is not in the focus of PR - we have just extracted the existing doc into a separate file.

jhadvig · 2020-08-17T14:49:23Z

docs/helm/endpoints_api.md

This doesn't seems right, since 502 RC should be used in case of server error response code indicates that the server, while acting as a gateway or proxy, received an invalid response from the upstream server.
400 and 404 should be used here.

might be, but that is not in the focus of PR - we have just extracted the existing doc into a separate file.

jhadvig · 2020-08-17T14:52:16Z

docs/helm/endpoints_api.md

Same as above

jhadvig · 2020-08-17T14:52:27Z

docs/helm/endpoints_api.md

same as above

might be, but that is not in the focus of PR - we have just extracted the existing doc into a separate file. If we need to do something, let's t do that in a separate PR, because that would also require the change of endpoint logic, not just the doc.

jhadvig · 2020-08-17T14:52:36Z

docs/helm/endpoints_api.md

might be, but that is not in the focus of PR - we have just extracted the existing doc into a separate file. If we need to do something, let's t do that in a separate PR, because that would also require the change of endpoint logic, not just the doc.

jhadvig · 2020-08-17T14:52:50Z

docs/helm/endpoints_api.md

might be, but that is not in the focus of PR - we have just extracted the existing doc into a separate file. If we need to do something, let's t do that in a separate PR, because that would also require the change of endpoint logic, not just the doc.

akashshinde · 2020-08-18T05:52:09Z

/test e2e-gcp-console

jhadvig

Thanks @pedjak for explanation... one last styling nit.

jhadvig · 2020-08-18T14:51:58Z

docs/helm/configure-3rdparty-repos-access.md

Suggested change

When requesting repo index through `/api/helm/charts/index.yaml endpoint, `HelmChartRepository` CRs and

When requesting repo index through `/api/helm/charts/index.yaml` endpoint, `HelmChartRepository` CRs and

jhadvig

/lgtm

openshift-ci-robot · 2020-09-11T05:22:37Z

@akashshinde: This pull request references Bugzilla bug 1878016, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1878016: Add documentation to describe configuring multiple helm chart repos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akashshinde · 2020-09-11T05:23:21Z

/bugzilla refresh

openshift-ci-robot · 2020-09-11T05:23:24Z

@akashshinde: This pull request references Bugzilla bug 1878016, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akashshinde · 2020-09-11T05:23:58Z

/bugzilla refresh

openshift-ci-robot · 2020-09-11T05:24:01Z

@akashshinde: This pull request references Bugzilla bug 1878016, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akashshinde · 2020-09-11T10:19:06Z

/bugzilla refresh

openshift-ci-robot · 2020-09-11T10:19:13Z

@akashshinde: This pull request references Bugzilla bug 1878016, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

akashshinde · 2020-09-11T10:20:20Z

@jhadvig can you approve this ?

spadgett · 2020-09-15T13:59:34Z

/approve

openshift-ci-robot · 2020-09-15T13:59:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-15T17:51:12Z

@akashshinde: All pull requests linked via external trackers have merged:

openshift/console#6324

Bugzilla bug 1878016 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1878016: Add documentation to describe configuring multiple helm chart repos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from alecmerdler and jhadvig August 13, 2020 03:35

pedjak force-pushed the helm-docs-update branch from 08b048a to 614d93c Compare August 17, 2020 13:48

jhadvig reviewed Aug 17, 2020

View reviewed changes

jhadvig reviewed Aug 18, 2020

View reviewed changes

Document configuring custom Helm chart repo(s)

41121a3

pedjak force-pushed the helm-docs-update branch from 614d93c to 41121a3 Compare August 18, 2020 16:44

jhadvig approved these changes Aug 19, 2020

View reviewed changes

openshift-ci-robot assigned jhadvig Aug 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020

akashshinde changed the title ~~Add documentation to describe configuring multiple helm chart repos~~ Bug 1878016: Add documentation to describe configuring multiple helm chart repos Sep 11, 2020

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 11, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 11, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020

openshift-merge-robot merged commit ec2a3fd into openshift:master Sep 15, 2020

spadgett added this to the v4.6 milestone Sep 16, 2020

	When requesting repo index through `/api/helm/charts/index.yaml endpoint, `HelmChartRepository` CRs and
	When requesting repo index through `/api/helm/charts/index.yaml` endpoint, `HelmChartRepository` CRs and

Bug 1878016: Add documentation to describe configuring multiple helm chart repos #6324

Bug 1878016: Add documentation to describe configuring multiple helm chart repos #6324

Uh oh!

Conversation

akashshinde commented Aug 13, 2020

Uh oh!

akashshinde commented Aug 13, 2020

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akashshinde commented Aug 18, 2020

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 11, 2020

Uh oh!

akashshinde commented Sep 11, 2020

Uh oh!

openshift-ci-robot commented Sep 11, 2020

Uh oh!

akashshinde commented Sep 11, 2020

Uh oh!

openshift-ci-robot commented Sep 11, 2020

Uh oh!

akashshinde commented Sep 11, 2020

Uh oh!

openshift-ci-robot commented Sep 11, 2020

Uh oh!

akashshinde commented Sep 11, 2020

Uh oh!

spadgett commented Sep 15, 2020

Uh oh!

openshift-ci-robot commented Sep 15, 2020

Uh oh!

openshift-ci-robot commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants