Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster #6588

pedjak · 2020-09-10T15:36:53Z

This fix enables the the requested usecase - an admin should be able to hide Helm chart browsing by removing all instances of HelmChartRepository in the cluster.

openshift/console-operator#458 needs to go in first.

openshift-ci-robot · 2020-09-10T15:46:57Z

@pedjak: This pull request references Bugzilla bug 1877861, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-10T15:49:51Z

@pedjak: This pull request references Bugzilla bug 1877861, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pedjak · 2020-09-10T15:51:25Z

/bugzilla-refresh

jhadvig · 2020-09-14T14:01:04Z

/retest

openshift-ci-robot · 2020-09-15T08:37:41Z

@pedjak: This pull request references Bugzilla bug 1877861, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-15T08:38:39Z

@pedjak: This pull request references Bugzilla bug 1877861, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/helm/chartproxy/repos.go

…stances are available in cluster

jhadvig

/lgtm

pedjak · 2020-09-15T16:08:31Z

/retest

pedjak · 2020-09-15T20:18:33Z

/retest

spadgett · 2020-09-16T13:20:51Z

/approve

openshift-ci-robot · 2020-09-16T13:21:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, pedjak, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pedjak · 2020-09-16T14:47:04Z

/retest

openshift-bot · 2020-09-16T15:50:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pedjak · 2020-09-16T16:39:10Z

/retest

pedjak · 2020-09-16T17:12:51Z

/retest

openshift-bot · 2020-09-16T18:27:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-16T22:59:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-17T03:45:35Z

@pedjak: All pull requests linked via external trackers have merged:

openshift/console#6588

Bugzilla bug 1877861 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from rhamilto and spadgett September 10, 2020 15:37

openshift-ci-robot added the component/backend Related to backend label Sep 10, 2020

pedjak changed the title ~~fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster~~ Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster Sep 10, 2020

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 10, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 10, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 10, 2020

jhadvig requested changes Sep 15, 2020

View reviewed changes

pkg/helm/chartproxy/repos.go Outdated Show resolved Hide resolved

fix: return empty Helm repo index file when no HelmChartRepository in…

a64f56c

…stances are available in cluster

pedjak force-pushed the appsvc-668 branch from 5bd6829 to a64f56c Compare September 15, 2020 13:59

jhadvig approved these changes Sep 15, 2020

View reviewed changes

openshift-ci-robot assigned jhadvig Sep 15, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020

openshift-merge-robot merged commit deb66a9 into openshift:master Sep 17, 2020

spadgett added this to the v4.6 milestone Sep 30, 2020

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster #6588

Bug 1877861: fix: return empty Helm repo index file when no HelmChartRepository instances are available in cluster #6588

Uh oh!

Conversation

pedjak commented Sep 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 10, 2020

Uh oh!

openshift-ci-robot commented Sep 10, 2020

Uh oh!

pedjak commented Sep 10, 2020

Uh oh!

jhadvig commented Sep 14, 2020

Uh oh!

openshift-ci-robot commented Sep 15, 2020

Uh oh!

openshift-ci-robot commented Sep 15, 2020

Uh oh!

Uh oh!

jhadvig left a comment

Choose a reason for hiding this comment

Uh oh!

pedjak commented Sep 15, 2020

Uh oh!

pedjak commented Sep 15, 2020

Uh oh!

spadgett commented Sep 16, 2020

Uh oh!

openshift-ci-robot commented Sep 16, 2020

Uh oh!

pedjak commented Sep 16, 2020

Uh oh!

openshift-bot commented Sep 16, 2020

Uh oh!

pedjak commented Sep 16, 2020

Uh oh!

pedjak commented Sep 16, 2020

Uh oh!

openshift-bot commented Sep 16, 2020

Uh oh!

openshift-bot commented Sep 16, 2020

Uh oh!

openshift-ci-robot commented Sep 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pedjak commented Sep 10, 2020 •

edited

Loading