Skip to content

Conversation

@rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Nov 11, 2020

I pulled down the latest and it looks like a couple of json files weren't checked in after yarn i18n was run. yarn i18n will remove trailing spaces and sometimes update string order. If we don't fix these, developers will see these files update every time they run yarn i18n.

@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Nov 11, 2020
@spadgett
Copy link
Member

I pulled down the latest and it looks like a couple of json files weren't checked in after yarn i18n was run. yarn i18n will remove trailing spaces and sometimes update string order.

We have a test that runs yarn i18n and fails if there is a diff... Do we have a bug in the test?

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2020
@rebeccaalpert
Copy link
Contributor Author

rebeccaalpert commented Nov 11, 2020

Totally possible there's a bug in the diff test. A lot has changed since it was written. I'll take a look and put up a second PR if needed.

@openshift-merge-robot openshift-merge-robot merged commit 41ec2c3 into openshift:master Nov 11, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants