Skip to content

gherkin script for quick search to add project in topology view- ODC-2925 #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 2, 2020
Merged

gherkin script for quick search to add project in topology view- ODC-2925 #7240

openshift-merge-robot merged 1 commit into from
Dec 2, 2020

Conversation

@sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Nov 17, 2020

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 17, 2020
gajanan-more
gajanan-more suggested changes Nov 24, 2020
View reviewed changes
...gration-tests/features/topology/quick_search_from_topology_views _to_add_to_project_ODC-2925 Outdated
Copy link
Contributor

@gajanan-more gajanan-more Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it display any message? If so, can you please add that message here.

Copy link
Contributor Author

@sanketpathak sanketpathak Nov 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is No result

Copy link
Contributor

@divyanshiGupta divyanshiGupta Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanketpathak it says No results

Copy link
Contributor Author

@sanketpathak sanketpathak Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

divyanshiGupta
divyanshiGupta reviewed Nov 25, 2020
View reviewed changes
...gration-tests/features/topology/quick_search_from_topology_views _to_add_to_project_ODC-2925 Outdated
Copy link
Contributor

@divyanshiGupta divyanshiGupta Nov 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So above you have mentioned it as quick search button and here you are adding Add to project button. Keep it same I would suggest. Quick search button and quick search bar.

Copy link
Contributor Author

@sanketpathak sanketpathak Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Add to project button and Add to project search bar is more appropriate as UX defines it that way

Copy link
Contributor

@divyanshiGupta divyanshiGupta Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Np. Just keep it same.

@sanketpathak sanketpathak force-pushed the gherkin_provide_quick_search_to_add_to_project branch 2 times, most recently from 4715de7 to 24f0d4f Compare November 26, 2020 16:01
@sanketpathak sanketpathak force-pushed the gherkin_provide_quick_search_to_add_to_project branch from 24f0d4f to 0784e13 Compare November 26, 2020 20:18
@divyanshiGupta
Copy link
Contributor

divyanshiGupta commented Nov 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@sanketpathak
Copy link
Contributor Author

sanketpathak commented Dec 1, 2020

/assign @makambalaji

@makambalaji
Copy link
Contributor

makambalaji commented Dec 2, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit dfb0850 into openshift:master Dec 2, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

2 more reviewers

@divyanshiGupta divyanshiGupta divyanshiGupta left review comments

@gajanan-more gajanan-more gajanan-more requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@divyanshiGupta divyanshiGupta

@makambalaji makambalaji

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

7 participants

@sanketpathak @divyanshiGupta @makambalaji @openshift-ci-robot @gajanan-more @spadgett @openshift-merge-robot