-
Notifications
You must be signed in to change notification settings - Fork 667
GitOps- Renamed Application Stages in nav to Environments #7272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitOps- Renamed Application Stages in nav to Environments #7272
Conversation
|
Hi @reginapizza. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
serenamarie125
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @reginapizza ! FYI @siamaksade
|
/test e2e-gcp-console |
|
/retest |
|
@reginapizza change console/frontend/packages/dev-console/src/components/gitops/GitOpsDetailsPage.tsx Line 78 in 548aa33
|
|
@reginapizza also please squash your commits into one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be devconsole~Application Environments? If so, this should fix the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this should be devconsole~Application Environments. @reginapizza please fix this.
6468364 to
d2ab17b
Compare
80759e3 to
638652d
Compare
|
@reginapizza: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
638652d to
a53526d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, reginapizza, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is only to rename the "Application Stages" section of the nav bar to be "Environments". GitOpsDetailsPage is also now shown as "Application Environments" instead of "Application Details".
@serenamarie125