Skip to content

Conversation

@reginaelyse
Copy link
Contributor

Environments
Environments- ApplicationEnvironments

This change is only to rename the "Application Stages" section of the nav bar to be "Environments". GitOpsDetailsPage is also now shown as "Application Environments" instead of "Application Details".

@serenamarie125

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @reginapizza. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

/ok-to-test
/cc @divyanshiGupta @rohitkrai03

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 20, 2020
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @reginapizza ! FYI @siamaksade

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 21, 2020
@reginaelyse
Copy link
Contributor Author

/test e2e-gcp-console

@spadgett
Copy link
Member

/retest

@divyanshiGupta
Copy link
Contributor

@reginapizza change Details to Environments here

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 27, 2020
@andrewballantyne
Copy link
Contributor

@reginapizza: The following tests failed, say /retest to rerun all failed tests:

ci/prow/frontend 102be80 link /test frontend

You'll need to run the I18n command in the package.json in order to get past the error in frontend.

@divyanshiGupta
Copy link
Contributor

@reginapizza also please squash your commits into one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be devconsole~Application Environments? If so, this should fix the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this should be devconsole~Application Environments. @reginapizza please fix this.

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/noobaa Related to noobaa-storage-plugin component/shared Related to console-shared labels Dec 1, 2020
@reginaelyse reginaelyse force-pushed the jira-issue-ODC-5144 branch 2 times, most recently from 80759e3 to 638652d Compare December 1, 2020 20:57
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 1, 2020

@reginapizza: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 80759e302f49ca99ca577be450d6e9677ff66fd2 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, reginapizza, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 01f0b55 into openshift:master Dec 2, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/noobaa Related to noobaa-storage-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants