Skip to content

Metal3 i18n form #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 2, 2020
Merged

Metal3 i18n form #7333

openshift-merge-robot merged 1 commit into from
Dec 2, 2020

Conversation

@yaacov
Copy link
Member

@yaacov yaacov commented Nov 25, 2020

More Metal3 plugin i18n strings.

Missing from this PR - Actions, Menu Items and Tabs from plugin.json file.

screenshot-localhost_9000-2020 11 25-20_58_07
screenshot-localhost_9000-2020 11 25-20_59_47
screenshot-localhost_9000-2020 11 25-21_00_46
screenshot-localhost_9000-2020 11 25-22_24_09

@openshift-ci-robot openshift-ci-robot added the component/metal3 Related to metal3-plugin label Nov 25, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 25, 2020

@pcbailey @rawagner @glekner @metalice please review

@yaacov
Copy link
Member Author

yaacov commented Nov 26, 2020

/retest

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Nov 26, 2020

/retest

yaacov
yaacov commented Nov 26, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
rawagner
rawagner suggested changes Nov 30, 2020
View reviewed changes
frontend/packages/metal3-plugin/src/components/modals/StopNodeMaintenanceModal.tsx Outdated
Copy link
Contributor

@rawagner rawagner Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should pass t function and translate strings within this function

frontend/packages/metal3-plugin/src/components/baremetal-nodes/dashboard/StatusCard.tsx Outdated
Copy link
Contributor

@rawagner rawagner Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you inline this ?

frontend/packages/metal3-plugin/src/components/baremetal-nodes/dashboard/StatusCard.tsx Outdated
Copy link
Contributor

@rawagner rawagner Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this a function ?
Can you also use camelcase ?

Copy link
Contributor

@rawagner rawagner Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also inline it together with BMO_DISABLED_ALERT ?

frontend/packages/metal3-plugin/src/components/baremetal-nodes/dashboard/StatusCard.tsx Outdated
Copy link
Contributor

@rawagner rawagner Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd use camelcase here too

frontend/packages/metal3-plugin/src/components/modals/PowerOffHostModal.tsx Outdated
Copy link
Contributor

@rawagner rawagner Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not construct sentences anymore

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
rawagner
rawagner reviewed Dec 1, 2020
View reviewed changes
frontend/packages/metal3-plugin/src/components/baremetal-nodes/table-filters.ts Outdated
Copy link
Contributor

@rawagner rawagner Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the keys start with metal3-plugin~ ?
Do we need // t('metal3-plugin~...) comments here ?

Copy link
Member Author

@yaacov yaacov Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow - thanks !

@rawagner
Copy link
Contributor

rawagner commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@yaacov
Copy link
Member Author

yaacov commented Dec 1, 2020

/retest

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Dec 1, 2020

/retest

@rawagner
Copy link
Contributor

rawagner commented Dec 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 99a7a15 into openshift:master Dec 2, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@honza honza Awaiting requested review from honza

2 more reviewers

@rawagner rawagner rawagner requested changes

@jtomasek jtomasek jtomasek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rawagner rawagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/metal3 Related to metal3-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

6 participants

@yaacov @rawagner @openshift-ci-robot @jtomasek @spadgett @openshift-merge-robot