Skip to content

i18n overview dashboard health state messages #7372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 2, 2020
Merged

i18n overview dashboard health state messages #7372

openshift-merge-robot merged 1 commit into from
Dec 2, 2020

Conversation

@afreen23
Copy link

@afreen23 afreen23 commented Dec 1, 2020

  • Created healthStateMessage function to update the strings when language changes, since the existing map healthStateMapping is used at various places for icons/priority only.
  • replaced healthStateMapping[state].message with healthStateMapping

Followup for this comment #7368 (comment)

@afreen23
Copy link
Author

afreen23 commented Dec 1, 2020

/assign @rawagner

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/noobaa Related to noobaa-storage-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Dec 1, 2020
@afreen23 afreen23 mentioned this pull request Dec 1, 2020
Merged
@rawagner
Copy link
Contributor

rawagner commented Dec 1, 2020

looks good, but please run yarn i18n to update the locale files

@afreen23
Copy link
Author

afreen23 commented Dec 1, 2020

looks good, but please run yarn i18n to update the locale files

Done!

@rawagner
Copy link
Contributor

rawagner commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
@afreen23
Copy link
Author

afreen23 commented Dec 1, 2020

/test /e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2020

@afreen23: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images
  • /test kubevirt-plugin

Use /test all to run the following jobs:

  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images
Details

In response to this:

/test /e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link
Author

afreen23 commented Dec 1, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

i18n overview dashboard health state messages
d70df97 
- Created `healthStateMessage` function to update the strings when language changes, since the  existing map `healthStateMapping` is used at various places for icons/priority only.
- replaced `healthStateMapping[state].message` with `healthStateMapping`
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@rawagner
Copy link
Contributor

rawagner commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 1, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ee3bfb1 into openshift:master Dec 2, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andybraren andybraren Awaiting requested review from andybraren

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@rawagner rawagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/noobaa Related to noobaa-storage-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.7

Development

Successfully merging this pull request may close these issues.

6 participants

@afreen23 @rawagner @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot