-
Notifications
You must be signed in to change notification settings - Fork 667
Bug 1906718: Use chart repository spec name when available #7466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906718: Use chart repository spec name when available #7466
Conversation
0c6e93c to
2b443e1
Compare
|
/assign |
|
verified locally, looks good |
frontend/packages/helm-plugin/src/catalog/providers/useHelmCharts.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/helm-plugin/src/catalog/providers/useHelmCharts.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/helm-plugin/src/catalog/providers/useHelmCharts.tsx
Outdated
Show resolved
Hide resolved
|
/hold |
|
/lgtm cancel |
2b443e1 to
3f3f4f1
Compare
|
/hold cancel |
3f3f4f1 to
a613672
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
@rohitkrai03: This pull request references Bugzilla bug 1906718, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rohitkrai03: All pull requests linked via external trackers have merged: Bugzilla bug 1906718 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-4977
Analysis / Root cause: The helm catalog and install upgrade page were using chart repository name from the index file which was not actual title of the repository but the
metadata.name.Solution Description: Fetch
HelmChartRepositoryCRs and look forspec.nameto get the title of each repository.Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Test setup:
Add below CR -
Browser conformance: