Bug 1920655: only show Cluster autoscalar on Cluster Settings if Clu… #7973

rhamilto · 2021-01-28T18:40:38Z

…sterAutoscalar CRD exists

openshift-ci-robot · 2021-01-28T18:40:42Z

@rhamilto: This pull request references Bugzilla bug 1920655, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1920655: only show Cluster autoscalar on Cluster Settings if Clu…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto · 2021-01-28T18:41:17Z

/bugzilla refresh

openshift-ci-robot · 2021-01-28T18:41:23Z

@rhamilto: This pull request references Bugzilla bug 1920655, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtaylor113

/lgtm

spadgett

Thanks @rhamilto 👍

frontend/public/components/cluster-settings/cluster-settings.tsx

spadgett · 2021-01-28T19:00:59Z

/hold

spadgett · 2021-01-28T19:01:34Z

@csrwng FYI

rhamilto · 2021-01-28T19:47:06Z

Updated. Please take another look, @spadgett

spadgett · 2021-01-29T13:43:59Z

/hold cancel

spadgett

Looks good, just one nit. Thanks @rhamilto

spadgett · 2021-01-29T13:49:04Z

frontend/public/components/cluster-settings/cluster-settings.tsx

I'd pull useFlag onto its own line outside the if since hooks always need to run in the same order every render. It's not a problem now since the if will always evaluate, but if someone added another condition later like isOpenShift && useFlag(FLAGS.CLUSTER_AUTOSCALER), it could break things. It's a good practice to have hooks on their own near the top of the function.

LOL. I had it on its own line and then optimized. That'll learn me.

…terAutoscalar CRD exists

rhamilto · 2021-01-29T14:06:50Z

Comment addressed. Thanks, @spadgett.

spadgett

/lgtm

👍

openshift-ci-robot · 2021-01-29T14:13:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rhamilto,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-01-29T15:05:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T15:18:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-01-29T15:31:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

rhamilto · 2021-01-29T15:39:13Z

/retest

rhamilto · 2021-01-29T15:41:47Z

/hold for openshift/release#15363

spadgett · 2021-01-29T16:06:27Z

/retest

spadgett · 2021-01-29T16:06:49Z

/hold cancel

spadgett · 2021-01-29T16:08:45Z

/override ci/prow/ceph-storage-plugin

The test should only run on PRs with ceph changes. A bad config change caused the failure.

openshift-ci-robot · 2021-01-29T16:09:06Z

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/ceph-storage-plugin

Details

In response to this:

/override ci/prow/ceph-storage-plugin

The test should only run on PRs with ceph changes. A bad config change caused the failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-01-29T17:28:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-01-29T21:39:20Z

@rhamilto: All pull requests linked via external trackers have merged:

openshift/console#7973

Bugzilla bug 1920655 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1920655: only show Cluster autoscalar on Cluster Settings if Clu…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhamilto assigned spadgett Jan 28, 2021

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 28, 2021

openshift-ci-robot added the component/core Related to console core functionality label Jan 28, 2021

openshift-ci-robot requested review from dtaylor113 and kyoto January 28, 2021 18:40

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Jan 28, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 28, 2021

dtaylor113 approved these changes Jan 28, 2021

View reviewed changes

openshift-ci-robot assigned dtaylor113 Jan 28, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

spadgett reviewed Jan 28, 2021

View reviewed changes

frontend/public/components/cluster-settings/cluster-settings.tsx Outdated Show resolved Hide resolved

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2021

rhamilto force-pushed the bz1920655 branch from a000e08 to d554600 Compare January 28, 2021 19:41

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2021

rhamilto force-pushed the bz1920655 branch from d554600 to 25a3bc5 Compare January 28, 2021 19:45

rhamilto force-pushed the bz1920655 branch 4 times, most recently from 473076e to 10bef8b Compare January 28, 2021 22:41

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021

spadgett reviewed Jan 29, 2021

View reviewed changes

Bug 1920655: only show Cluster autoscalar on Cluster Settings if Clus…

8c04326

…terAutoscalar CRD exists

rhamilto force-pushed the bz1920655 branch from 10bef8b to 8c04326 Compare January 29, 2021 14:06

spadgett approved these changes Jan 29, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021

openshift-merge-robot merged commit f79f7da into openshift:master Jan 29, 2021

rhamilto deleted the bz1920655 branch February 1, 2021 13:21

spadgett added this to the v4.7 milestone Feb 1, 2021

Bug 1920655: only show Cluster autoscalar on Cluster Settings if Clu… #7973

Bug 1920655: only show Cluster autoscalar on Cluster Settings if Clu… #7973

Uh oh!

Conversation

rhamilto commented Jan 28, 2021

Uh oh!

openshift-ci-robot commented Jan 28, 2021

Uh oh!

rhamilto commented Jan 28, 2021

Uh oh!

openshift-ci-robot commented Jan 28, 2021

Uh oh!

dtaylor113 left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spadgett commented Jan 28, 2021

Uh oh!

spadgett commented Jan 28, 2021

Uh oh!

rhamilto commented Jan 28, 2021

Uh oh!

spadgett commented Jan 29, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

rhamilto Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

rhamilto commented Jan 29, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 29, 2021

Uh oh!

openshift-bot commented Jan 29, 2021

Uh oh!

openshift-bot commented Jan 29, 2021

Uh oh!

openshift-bot commented Jan 29, 2021

Uh oh!

rhamilto commented Jan 29, 2021

Uh oh!

rhamilto commented Jan 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spadgett commented Jan 29, 2021

Uh oh!

spadgett commented Jan 29, 2021

Uh oh!

spadgett commented Jan 29, 2021

Uh oh!

openshift-ci-robot commented Jan 29, 2021

Uh oh!

openshift-bot commented Jan 29, 2021

Uh oh!

openshift-ci-robot commented Jan 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rhamilto commented Jan 29, 2021 •

edited

Loading