Better Firehose #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
alecmerdler
force-pushed
the
CONSOLE-327
branch
2 times, most recently
from
3dd5ee2 to
4552878
Compare
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
Contributor
|
@alecmerdler: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-bot
added
the
needs-rebase
jeff-phillips-18
pushed a commit
to jeff-phillips-18/console
that referenced
this pull request
Oct 15, 2019
Replace arrow markers with ConnectorArrow component
TimothyAsirJeyasing
pushed a commit
to TimothyAsirJeyasing/console
that referenced
this pull request
Aug 3, 2022
fix: Add number in front of Storage System in Status Card
openshift-merge-robot
pushed a commit
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces
firehoseForfactory function, which returns aFirehose-like component that accepts a render callback and provides type autocompletion based on theresourcesprovided.Changes
firehosemodulefirehoseForfactory function and tests<Firehose>instances in TypeScript components tofirehoseForAddresses https://jira.coreos.com/browse/CONSOLE-327
Previously https://github.com/coreos-inc/bridge/pull/2189