CONSOLE-2758: Bump webpack-cli and webpack-dev-server to latest version #8269
Conversation
openshift-ci-robot
added
the
approved
vojtechszocs
force-pushed
the
bump-webpack-cli
branch
from
d05a876 to
364a057
Compare
spadgett
changed the title
|
Right now, latest |
|
Since this is a dev-only dependency, this does not need QE review. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
zherman0
left a comment
zherman0
left a comment
There was a problem hiding this comment.
Looks good, will complete the other bump PRs once this merges
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, vojtechszocs, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Holding until #8289 merges to unblock CI. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
The webpack-cli upgrade in openshift/console#8269 was only made in 4.8. The analyze job will fail in 4.7 due to the older webpack-cli version, so we should remain on v21 for 4.7.
6 participants
webpack-clibumped from3.3.9to4.5.0webpack-dev-serverbumped from3.11.0to3.11.1@types/webpack-dev-serverdev-dependencyThe
devscript has been updated to invokewebpack-dev-servervia webpack CLI.Starting with
webpack-cliv4, this is the standard way to run the dev-server. See here for details.The
analyzescript has been updated to match changes inwebpack-cliv4. See here for details.Our main
yarn.lockfile contains some resolutions pointing tohttps://registry.npmjs.org/instead of the expectedhttps://registry.yarnpkg.com/and found this Yarn issue which is fixed in Yarn v2 only.