Skip to content

odc-5571-fixed page details related smoke test case #8287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 8, 2021
Merged

odc-5571-fixed page details related smoke test case #8287

openshift-merge-robot merged 1 commit into from
Mar 8, 2021

Conversation

@makambalaji
Copy link
Contributor

@makambalaji makambalaji commented Mar 3, 2021

Problem: page details related smoke test cases are failed
Solution: updated the locator for add page and moved the pipelines test case to pipelines folder

Jira Id: https://issues.redhat.com/browse/ODC-5571

image

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Mar 3, 2021
@openshift-ci-robot openshift-ci-robot added component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2021
@sanketpathak
Copy link
Contributor

sanketpathak commented Mar 3, 2021

Tests are passing
Screenshot from 2021-03-03 19-22-56
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 3, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Mar 3, 2021

Holding until #8289 merges to unblock CI.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@spadgett
Copy link
Member

spadgett commented Mar 5, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2021
@makambalaji
Copy link
Contributor Author

makambalaji commented Mar 6, 2021

@sanketpathak - Can you please add lgtm again. Due to rebase lgtm got removed

@sanketpathak
Copy link
Contributor

sanketpathak commented Mar 8, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f4a98b0 into openshift:master Mar 8, 2021
@spadgett spadgett added this to the v4.8 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gajanan-more gajanan-more Awaiting requested review from gajanan-more

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@sanketpathak sanketpathak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/pipelines Related to pipelines-plugin lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.8

Development

Successfully merging this pull request may close these issues.

6 participants

@makambalaji @sanketpathak @openshift-bot @spadgett @openshift-ci-robot @openshift-merge-robot