Migrate all static AddAction extensions to dynamic extensions #8371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/helm
Contributor
|
@rohitkrai03 doesn't #8363 need to merge first otherwise localization of |
Contributor
Author
@christianvogt Yeah, i am trying your PR with my branch. Will rebase my branch to include your changes once everything works fine. |
vojtechszocs
suggested changes
Mar 11, 2021
frontend/packages/console-dynamic-plugin-sdk/src/extensions/add-actions.ts
Outdated
Show resolved
Hide resolved
frontend/packages/console-dynamic-plugin-sdk/src/extensions/add-actions.ts
Outdated
Show resolved
Hide resolved
rohitkrai03
force-pushed
the
migrate-add-action
branch
from
896502c to
c5b1f7f
Compare
openshift-ci-robot
added
the
kind/i18n
Contributor
|
LGTM on last two commits. |
rohitkrai03
force-pushed
the
migrate-add-action
branch
2 times, most recently
from
4fcc6fc to
674695e
Compare
frontend/packages/console-dynamic-plugin-sdk/src/extensions/add-actions.ts
Outdated
Show resolved
Hide resolved
frontend/packages/console-dynamic-plugin-sdk/src/utils/common.ts
Outdated
Show resolved
Hide resolved
rohitkrai03
force-pushed
the
migrate-add-action
branch
from
674695e to
7bfc2ff
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8363
Fixes: https://issues.redhat.com/browse/ODC-5550
Analysis / Root cause: All
AddActionextensions currently use static extensibility mechanism.Solution Description: Move all static AddAction extensions to use dynamic extensibility.
Screen shots / Gifs for design review: No UI change.
Browser conformance: