-
Notifications
You must be signed in to change notification settings - Fork 667
CONSOLE-2508: Memsource automation #8819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2508: Memsource automation #8819
Conversation
02ee815 to
48803d2
Compare
48803d2 to
0ab51b7
Compare
|
Updated PR to add the download script. Let me know if you have feedback. I also addressed the feedback on script #1. |
ace9179 to
bd1356c
Compare
|
Just realized I didn't handle creating a new commit and PR in the script. I'll see if I can add that in. |
bd1356c to
eca6f31
Compare
3d7dfc1 to
eca6f31
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dtaylor113, rebeccaalpert The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Nice job @rebeccaalpert! Nice bit of scripting! :-) |
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rebeccaalpert A lot of variables are still missing quotes. Can you run shellcheck on the scripts and fix any errors? Thanks!
85da1bf to
c24bb9c
Compare
|
New changes are detected. LGTM label has been removed. |
|
Fixed the stuff |
|
Hey, @rebeccaalpert. There still seem to be warnings. Can you take another look? (Don't worry about the "not following" warnings.) |
|
@spadgett - I'm not getting those anyway: |
c24bb9c to
2f167f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I think it would be better to just avoid the special characters in the filename altogether, particular if Memsource does weird things with them. Then we can also avoid needing the rename utility. Would a convention like my-package__my-namespace be simpler? (Similar to BEM names.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make the change, but I'd have to rework two other scripts and we won't be able to download any older files with this system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make the change, but I'd have to rework two other scripts.
I think it's worth doing.
|
Addressed feedback. I adjusted naming scheme in a separate commit so we can drop it if needed. Note that this change will prevent us from using any of the scripts for dealing with translation files that we've already sent over under the original naming scheme (we have one batch currently in process). |
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rebeccaalpert
1bd3474 to
015568b
Compare
|
All set. |
Added scripts to handle project creation, file generation, and file upload for Memsource, as well as file download and import. Fixes https://issues.redhat.com/projects/CONSOLE/issues/CONSOLE-2508
015568b to
fa35b9d
Compare
|
@spadgett; I squashed; let me know if this is good to go or if you have additional feedback. I used it to upload Sprint 200, but Sprint 199 will be in the old format and we'll have to revert the tools to the old naming scheme locally to import those. |
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @rebeccaalpert.
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added one script to handle project creation, file generation, and file upload for Memsource and a second to handle download and file import into OpenShift.
I used https://github.com/unofficial-memsource/memsource-cli-client instead of the Ansible collection because I couldn't get the collection to work. We can always circle back and switch to that later.
Documentation is in the files themselves; installing the memsource cli client and providing credentials is required for use. One script also requires the rename utility.
I also made some revisions to the other scripts in our little tool chain here.
Fixes https://issues.redhat.com/projects/CONSOLE/issues/CONSOLE-2508.