Skip to content

Enable import order eslint rule and fix related lint errors #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 14, 2021
Merged

Enable import order eslint rule and fix related lint errors #9120

openshift-merge-robot merged 1 commit into from
Jun 14, 2021

Conversation

@rohitkrai03
Copy link
Contributor

@rohitkrai03 rohitkrai03 commented Jun 2, 2021

Fixes: https://issues.redhat.com/browse/ODC-3670

Analysis / Root cause: During ESLint upgrade we disabled import/order eslint rule due to some issues.

Solution Description: Enable import/order eslint rule and fix all the lint errors.

Screen shots / Gifs for design review: No UI change.

Unit test coverage report: No changes in tests. All tests are passing.

Screenshot 2021-06-02 at 9 02 33 PM

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/git-service Related to git-service labels Jun 2, 2021
@openshift-ci openshift-ci bot requested review from andybraren and bipuladh June 2, 2021 15:40
@openshift-ci openshift-ci bot added component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing labels Jun 2, 2021
andrewballantyne
andrewballantyne reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Few questions inquires to spark conversation.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jun 2, 2021

cc @spadgett @TheRealJon FYI - it was disabled in #3747

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jun 3, 2021
@rohitkrai03 rohitkrai03 force-pushed the import-order-fix branch 2 times, most recently from 26e893a to 785c42e Compare June 3, 2021 12:11
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2021
@invincibleJai
Copy link
Member

invincibleJai commented Jun 7, 2021

verified the changes in bot and work as expected

@rohitkrai03
Copy link
Contributor Author

rohitkrai03 commented Jun 7, 2021

/hold

We are going to wait for the 4.9 master to open as the PR is huge and touches almost all files in console. It would be safer to get this merged next week.

@rohitkrai03 rohitkrai03 force-pushed the import-order-fix branch 2 times, most recently from 560fa05 to f0f1bff Compare June 14, 2021 12:23
@rohitkrai03
Copy link
Contributor Author

rohitkrai03 commented Jun 14, 2021

/hold cancel

The PR is ready to be merged now that 4.9 master is open.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2021
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jun 14, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@rohitkrai03
Copy link
Contributor Author

rohitkrai03 commented Jun 14, 2021

/retest

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jun 14, 2021

@rohitkrai03 Looks like there is another lint --fix you need to run. Sorts are out aligned on a couple files.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@rohitkrai03
Copy link
Contributor Author

rohitkrai03 commented Jun 14, 2021

@rohitkrai03 Looks like there is another lint --fix you need to run. Sorts are out aligned on a couple files.

@andrewballantyne Done.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jun 14, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jun 14, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jun 14, 2021

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit 852743d into openshift:master Jun 14, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 14, 2021
@rohitkrai03 rohitkrai03 deleted the import-order-fix branch July 24, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andybraren andybraren Awaiting requested review from andybraren

@bipuladh bipuladh Awaiting requested review from bipuladh

1 more reviewer

@andrewballantyne andrewballantyne andrewballantyne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrewballantyne andrewballantyne

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.9

Development

Successfully merging this pull request may close these issues.

6 participants

@rohitkrai03 @andrewballantyne @spadgett @openshift-bot @invincibleJai @openshift-merge-robot