Update PF to 2021-11

[jcaianirh]

Manual and unit tests passed.

[jcaianirh]

/hold for testing

[jcaianirh]

/cc @sg00dwin

[dtaylor113]

/lgtm

[jcaianirh]

/retest

[jcaianirh]

/retest

[jcaianirh]

/retest

[spadgett]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcaianirh]

/retest

[spadgett]

@jcaianirh This still has a hold. Is that intentional?

@kdoberst Looks like this will conflict with your PR.

[jcaianirh]

@spadgett there is a test that isn't passing e2e: actions-on-helm-release-after-upgrade.feature
I'm making sure pf isn't contributing to the failure

[openshift-ci]

@jcaianirh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	95cee26	link	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[spadgett]

@jcaianirh Looks like there are accessibility violations:

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_console/9871/pull-ci-openshift-console-master-e2e-gcp-console/1430605449731772416/artifacts/e2e-gcp-console/test/artifacts/gui_test_screenshots/cypress/screenshots/helm/actions-on-helm-release-after-upgrade.feature/Actions%20menu%20on%20Helm%20page%20after%20helm%20chart%20upgrade%20HR-08-TC01%20--%20before%20each%20hook%20(failed)%20(attempt%202).png

[spadgett]

2 accessibility violations were detected for Developer perspective with guide tour modal
┌─────────┬───────────────────────┬────────────┬─────────────────────────────────────────────────────────────────────────┬───────┐
│ (index) │          id           │   impact   │                               description                               │ nodes │
├─────────┼───────────────────────┼────────────┼─────────────────────────────────────────────────────────────────────────┼───────┤
│    0    │ 'duplicate-id-active' │ 'serious'  │     'Ensures every id attribute value of active elements is unique'     │   1   │
│    1    │  'duplicate-id-aria'  │ 'critical' │ 'Ensures every id attribute value used in ARIA and in labels is unique' │   1   │
└─────────┴───────────────────────┴────────────┴─────────────────────────────────────────────────────────────────────────┴───────┘
2 accessibility violations were detected for Developer perspective with guide tour modal
┌─────────┬───────────────────────┬────────────┬─────────────────────────────────────────────────────────────────────────┬───────┐
│ (index) │          id           │   impact   │                               description                               │ nodes │
├─────────┼───────────────────────┼────────────┼─────────────────────────────────────────────────────────────────────────┼───────┤
│    0    │ 'duplicate-id-active' │ 'serious'  │     'Ensures every id attribute value of active elements is unique'     │   1   │
│    1    │  'duplicate-id-aria'  │ 'critical' │ 'Ensures every id attribute value used in ARIA and in labels is unique' │   1   │
└─────────┴───────────────────────┴────────────┴─────────────────────────────────────────────────────────────────────────┴───────┘

[spadgett]

It's great that our automation caught this since it's something you'd never notice just looking at the UI.

[kdoberst]

@kdoberst Looks like this will conflict with your PR.

It might produce a conflict, but the changes in this PR should work fine with the code in my PR.

[jcaianirh]

@dtaylor113 summarized the testing issues seen with this pr nicely:

1. Failed to get "[data-test-id="item-filter"] due to Install Helm Chart failure of "An error occurred Failed to install helm chart: cannot re-use a name ["nodejs-ex-m"] that is still in use".

   • The "item-filter" is on the resultant topology view, but failure causes nav to remain on the installation form.
   • This test flake is not because of this pr and is seen elsewhere here: other ci instances of this failure

2. The failure causes helm chart installation form to remain on screen, which the a11y tests against and it does find legit accessibility violations, in PF accordion. This may be fixed by the fix for the prior issue, or the ability for us to add unique id's

3. Assuming you get past issues #1 and #2 above (which you might as it seems to be a flake, I was able to install helm chart locally using name "nodejs-ex-m"). I am able to reproduce the click target on the topology right-click context menu. I do see 'hand pointer' cursor over text, and 'arrow pointer' on rest of menu item. This issue is already documented here: https://issues.redhat.com/browse/ODC-6212 and being worked on by @rohitkrai03.

   • At this point the CI right-clicks and clicks the "Upgrade" context menu item, but clicks the box, not the text, and thus fails to launch/open the 'Upgrade helm release' form.

For Issue #3, though the dev-console code is not following best practices (using a pf MenuItem inside DropdownItem), we can see a change in behavior from pre 2021-11 and post 2021-11 as shown in the videos below:

Before this pr:
https://user-images.githubusercontent.com/35978579/131013551-9ff2cfb5-2779-4e0b-8415-fab7f4b6941a.mov

After this pr:
https://user-images.githubusercontent.com/35978579/131013565-a947fcae-0474-4173-b9d0-c9019ad5e1b6.mov

UPDATE: This is looking like the CI failures/flakes need to be resolved by dev-console team. The fix might also fix the a11y violations.

[jcaianirh]

@rohitkrai03 will wait on your fix for the helm e2e tests to resolve the failures in this pr, and rebase when you've got a pr merged.

[openshift-ci]

@jcaianirh: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rohitkrai03]

@jcaianirh I've raised a PR that fixes the topology context menu issue - #9930. Please take a look. This should fix the #3 issue that is causing e2e test failures.

[rohitkrai03]

@jcaianirh My PR that fixed topology context menu merged.

[spadgett]

We might hold this until 4.10 unless there is a specific bug we need to fix with this update.