Skip to content

Fix HostPortOrFile to support IPv6 addresses with zone (#3527)#21

Closed
ironcladlou wants to merge 1 commit intoopenshift:masterfrom
ironcladlou:pick-3527
Closed

Fix HostPortOrFile to support IPv6 addresses with zone (#3527)#21
ironcladlou wants to merge 1 commit intoopenshift:masterfrom
ironcladlou:pick-3527

Conversation

@ironcladlou
Copy link
Copy Markdown

Supersedes #19. @bcrochet, does this mess anything up if we merge in advance of the forthcoming bump PRs?

1. The HostPortOrFile tests don't have any IPv6 tests. This adds some.
2. The HostPortOrFile breaks if any of the addresses have IPv6 zone
defined. ParseIP does not handle %zone anymore.

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 21, 2020
@openshift-ci-robot
Copy link
Copy Markdown

@ironcladlou: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 542733f link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ironcladlou
Copy link
Copy Markdown
Author

Superseded by #22

/close

@openshift-ci-robot
Copy link
Copy Markdown

@ironcladlou: Closed this PR.

Details

In response to this:

Superseded by #22

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jjkiely pushed a commit to Kuadrant/coredns that referenced this pull request Sep 24, 2025
Update base CSV, add release prep script and docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants