Skip to content

Bug 1860142: Adds HealthcheckBrokenCount to forward plugin#35

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danehans:fwd_metric_broken_health
Jul 31, 2020
Merged

Bug 1860142: Adds HealthcheckBrokenCount to forward plugin#35
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
danehans:fwd_metric_broken_health

Conversation

@danehans
Copy link
Copy Markdown

@danehans danehans commented Jul 24, 2020

1. Why is this pull request needed and what does it do?

This PR is required for the forward plugin to produce the coredns_forward_healthcheck_broken_count_total metric. It was previously missing.

2. Which issues (if any) are related?

This is a manual cherry-pick of coredns#4021 and fixes https://bugzilla.redhat.com/show_bug.cgi?id=1860142

3. Which documentation changes (if any) need to be made?

The forward plugin already documents this metic.

4. Does this introduce a backward incompatible change or deprecation?

No.

Note: The forward plugin was introduced in OCP v4.5 and therefore this PR should be backported accordingly.

/assign @Miciah @knobunc

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 24, 2020

@danehans: This pull request references Bugzilla bug 1860142, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1860142: Adds HealthcheckBrokenCount to forward plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 24, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@Miciah
Copy link
Copy Markdown

Miciah commented Jul 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Jul 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7d7ed49 into openshift:master Jul 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 31, 2020

@danehans: Some pull requests linked via external trackers have merged: openshift/coredns#35. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1860142: Adds HealthcheckBrokenCount to forward plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans danehans deleted the fwd_metric_broken_health branch July 31, 2020 17:41
@danehans
Copy link
Copy Markdown
Author

danehans commented Jul 31, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 31, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 31, 2020

@danehans: new pull request created: #36

Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jjkiely pushed a commit to Kuadrant/coredns that referenced this pull request Sep 24, 2025
@maksymvavilov
openshiftGH-35 randomize validation reconcilation
f3e5c35
jjkiely pushed a commit to Kuadrant/coredns that referenced this pull request Sep 24, 2025
@maleck13
Merge pull request openshift#73 from Kuadrant/openshiftGH-35
b5a7642 
openshiftGH-35 randomize validation time
bentito pushed a commit to bentito/coredns that referenced this pull request Nov 21, 2025
@openshift-merge-robot
Merge pull request openshift#35 from danehans/fwd_metric_broken_health
c3606da 
Bug 1860142: Adds HealthcheckBrokenCount to forward plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miciah Miciah Awaiting requested review from Miciah

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@Miciah Miciah

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@danehans @openshift-ci-robot @Miciah @openshift-bot @openshift-cherrypick-robot @knobunc @openshift-merge-robot