Rename api group to `sharedresource.openshift.io` by adambkaplan · Pull Request #39 · openshift/csi-driver-shared-resource

adambkaplan · 2021-07-28T19:07:18Z

Rename api group to sharedresource.storage.openshift.io.
Update base CRD definition and type registration with new group name.
Regenerated deployment YAMLs.
Rename pkg/api/projectedresource to pkg/api/sharedresource
Rename arguments for update/generated.sh to use new name
Regenerate informers and listers
Rename golang package imports
Update controller with new informer factory name
Update e2e tests to use new client
Rename CRD manifest to "sharedresource"
Move base YAML manifest to the sharedresource/v1alpha1 directory
Add rename to update-crd.sh

Rename image to csi-driver-shared-resource for CI.

coreydaley · 2021-08-03T15:21:36Z

/retest

- Rename api group to sharedresource.storage.openshift.io. - Update base CRD definition and type registration with new group name. - Regenerated deployment YAMLs.

- Rename pkg/api/projectedresource to pkg/api/sharedresource - Rename arguments for update/generated.sh to use new name - Regenerate informers and listers - Rename golang package imports - Update controller with new informer factory name - Update e2e tests to use new client

- Rename CRD manifest to "sharedresource" - Move base YAML manifest to the sharedresource/v1alpha1 directory - Add rename to update-crd.sh and deploy-in-CI.sh

- Use "csi-driver-shared-resource" for namespace and core components - Add suffixes for cluster role bindings - Rename csi driver deployment manifests to use desired ordering - Clarify comments in deploy scripts

- Regenerate client - Update SAR check to use new api group - Use new group name when creating RBAC in test framework

openshift-ci · 2021-08-03T16:07:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coreydaley · 2021-08-03T18:52:44Z

@adambkaplan I think that https://github.com/openshift/csi-driver-shared-resource/blob/master/Dockerfile needs to be updated to reflect the new github repository name and go package name?

coreydaley · 2021-08-03T18:53:54Z

From the test logs:

2021-08-03T16:13:07.904133683Z STEP 8: COPY --from=builder /go/src/github.com/openshift/csi-driver-projected-resource/_output/csi-driver-projected-resource /usr/bin/
2021-08-03T16:13:08.690272181Z STEP 9: ENTRYPOINT null
2021-08-03T16:13:08.690272181Z STEP 10: CMD ["/usr/bin/csi-driver-projected-resource"]

Update component names to check in e2e tests.

- Update component names in install docs - Update driver name in example YAML.

Fix driver name used in tests

adambkaplan · 2021-08-04T14:39:13Z

I honestly don't know how CI works without registering the CSIDriver object. Kube can't create pods if the CSI driver isn't registered with the cluster. I don't see anything in openshift/release or the make commands which indicate we register the CSI driver object in our test.

coreydaley · 2021-08-04T15:36:27Z

@adambkaplan

 "message": "MountVolume.SetUp failed for volume \"my-csi-volume\" : rpc error: code = InvalidArgument desc = the csi driver volumeAttribute 'share' reference had an error: share.projectedresource.storage.openshift.io \"e2e-test-csi-driver-projected-resource-kdjtt\" not found",

adambkaplan · 2021-08-04T17:14:22Z

@coreydaley this is the moment where I screamed at the top of my lungs, "WHAT'S GOING ON?!" [1]

I suspect that either:

We aren't deploying the driver we want in CI
The client code that we're generating in this tree is somehow hard-coding the previous apigroup.

The only way I think we can address the situation is close this PR, and start fresh with generated code from openshift/api and openshift/client-go vendored in.

[1] https://www.youtube.com/watch?v=6NXnxTNIWkc

openshift-ci · 2021-08-06T17:46:29Z

@adambkaplan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-operator	`3b6a5df`	link	`/test e2e-aws-operator`
ci/prow/e2e-aws-operator-slow	`3b6a5df`	link	`/test e2e-aws-operator-slow`
ci/prow/e2e-aws-operator-disruptive	`3b6a5df`	link	`/test e2e-aws-operator-disruptive`
ci/prow/e2e-aws-csi-driver	`3b6a5df`	link	`/test e2e-aws-csi-driver`
ci/prow/e2e-aws-csi-driver-slow	`3b6a5df`	link	`/test e2e-aws-csi-driver-slow`
ci/prow/e2e-aws-csi-driver-disruptive	`3b6a5df`	link	`/test e2e-aws-csi-driver-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2021-08-06T17:46:32Z

@adambkaplan: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2021-08-16T15:49:19Z

/close

openshift-ci · 2021-08-16T15:51:43Z

@adambkaplan: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot requested review from coreydaley and otaviof July 28, 2021 19:08

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021

adambkaplan force-pushed the rename-api-group branch from 4ed03e4 to 62a4177 Compare July 28, 2021 20:35

adambkaplan changed the title ~~Rename api group to sharedresource.storage.openshift.io~~ Rename api group to sharedresource.openshift.io Jul 29, 2021

adambkaplan mentioned this pull request Jul 29, 2021

BUILD-284: Relocate shared resources api into openshift/api repository openshift/api#979

Merged

Rename image for CI

ffa4278

Rename image to csi-driver-shared-resource for CI.

adambkaplan added 7 commits August 3, 2021 12:04

Rename api group

7960a06

- Rename api group to sharedresource.storage.openshift.io. - Update base CRD definition and type registration with new group name. - Regenerated deployment YAMLs.

Rename CRD YAML manifest

9372039

- Rename CRD manifest to "sharedresource" - Move base YAML manifest to the sharedresource/v1alpha1 directory - Add rename to update-crd.sh and deploy-in-CI.sh

Drop storage subdomain

670edfb

Update deployment names

1332f26

- Use "csi-driver-shared-resource" for namespace and core components - Add suffixes for cluster role bindings - Rename csi driver deployment manifests to use desired ordering - Clarify comments in deploy scripts

Fixes to api group name

67bce73

- Regenerate client - Update SAR check to use new api group - Use new group name when creating RBAC in test framework

fix default namespace for client

68192b9

adambkaplan force-pushed the rename-api-group branch from df55525 to 68192b9 Compare August 3, 2021 16:04

adambkaplan added 5 commits August 3, 2021 15:05

Fix CI deployment test

ec43fe2

Update component names to check in e2e tests.

Update docs

8b84418

- Update component names in install docs - Update driver name in example YAML.

Fix driver name

7bd4ab2

Fix driver name used in tests

Fix driver name in main.go

64a2089

Register CSIDriver when running tests

3b6a5df

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2021

openshift-ci Bot closed this Aug 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename api group to `sharedresource.openshift.io`#39

Rename api group to `sharedresource.openshift.io`#39
adambkaplan wants to merge 13 commits intoopenshift:masterfrom
adambkaplan:rename-api-group

adambkaplan commented Jul 28, 2021

Uh oh!

coreydaley commented Aug 3, 2021

Uh oh!

openshift-ci Bot commented Aug 3, 2021

Uh oh!

coreydaley commented Aug 3, 2021

Uh oh!

coreydaley commented Aug 3, 2021 •

edited

Loading

Uh oh!

adambkaplan commented Aug 4, 2021

Uh oh!

coreydaley commented Aug 4, 2021

Uh oh!

adambkaplan commented Aug 4, 2021

Uh oh!

openshift-ci Bot commented Aug 6, 2021

Uh oh!

openshift-ci Bot commented Aug 6, 2021

Uh oh!

adambkaplan commented Aug 16, 2021

Uh oh!

openshift-ci Bot commented Aug 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

adambkaplan commented Jul 28, 2021

Uh oh!

coreydaley commented Aug 3, 2021

Uh oh!

openshift-ci Bot commented Aug 3, 2021

Uh oh!

coreydaley commented Aug 3, 2021

Uh oh!

coreydaley commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adambkaplan commented Aug 4, 2021

Uh oh!

coreydaley commented Aug 4, 2021

Uh oh!

adambkaplan commented Aug 4, 2021

Uh oh!

openshift-ci Bot commented Aug 6, 2021

Uh oh!

openshift-ci Bot commented Aug 6, 2021

Uh oh!

adambkaplan commented Aug 16, 2021

Uh oh!

openshift-ci Bot commented Aug 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coreydaley commented Aug 3, 2021 •

edited

Loading