BUILD-365: Rename shared resource csi driver operand

[coreydaley]

No description provided.

[coreydaley]

/assign @gabemontero

[gabemontero]

/hold
/approve
/lgtm

@coreydaley - please inspect the mustgather and confirm our daemonset / pods in fact have the correct name, and that if you look at their pod logs, there are no glaring errors

yes, I understand the wait for daemonset stuff would not pass without it, but given the unexpected roadblocks we've hit with this stuff, lets make sure there isn't a surprise waiting for us

for example, am I correct in thinking that the operator still would have created items with the old csi-hostpath name until your operator PR merges? I think I may be ... in which case, maybe the tests are passing cause the old daemonset is still there, etc.

given this in between state, let's see if we can catch any boo boo's before you move back to your operator PR

but if the logs look OK, cancel the hold and we'll go from there

thanks

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [gabemontero]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gabemontero]

NOTE to any readers here - we are doing this rename at the behest of the storage team (who asked in slack)

[coreydaley]

@gabemontero
The operator test was failing because it was running the tests from this repository, which were looking for the old name, even though the new name was being used.

I have manually confirmed via the must-gather that the pods have the new shared-resource-csi-driver-node name and that the logs do not show any weird errors.

You can verify here (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_csi-driver-shared-resource-operator/14/pull-ci-openshift-csi-driver-shared-resource-operator-master-e2e-aws-csi-driver/1452638647856664576) that the tests failed while looking for the csi-hostpathplugin daemonset in the tests from the csi-driver-shared-resource repository.
If there is anything that you can think of that you would like me to verify, let me know!

[coreydaley]

/hold cancel

[gabemontero]

@gabemontero The operator test was failing because it was running the tests from this repository, which were looking for the old name, even though the new name was being used.

I have manually confirmed via the must-gather that the pods have the new shared-resource-csi-driver-node name and that the logs do not show any weird errors.

You can verify here (https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_csi-driver-shared-resource-operator/14/pull-ci-openshift-csi-driver-shared-resource-operator-master-e2e-aws-csi-driver/1452638647856664576) that the tests failed while looking for the csi-hostpathplugin daemonset in the tests from the csi-driver-shared-resource repository. If there is anything that you can think of that you would like me to verify, let me know!

Not sure why you linked to you operator PRs tests ... I was curious about the must gather from this PRs e2es.

Looking at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_csi-driver-shared-resource/64/pull-ci-openshift-csi-driver-shared-resource-master-e2e-aws-csi-driver/1452690547113201664

and its must gather, I only see the new name on the pod list

but duh, since this is still testing on a normal cluster (vs. a tech preview cluster), which needs my Jira :-/ ... that is in fact expected, as the operator will not have done anything on a non-tech preview cluster

let's move on to openshift/csi-driver-shared-resource-operator#14 which should be doing CI now in a tech preview cluster, given openshift/release#22927 has merged, and see what happens