Skip to content

Enhancement to refine ClusterVersion history pruning#1153

Merged
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
jottofar:ota-661
Jun 24, 2022
Merged

Enhancement to refine ClusterVersion history pruning#1153
openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
jottofar:ota-661

Conversation

@jottofar
Copy link
Copy Markdown
Contributor

@jottofar jottofar commented Jun 10, 2022

Reference OTA-664.

@openshift-ci openshift-ci Bot requested review from vrutkovs and wking June 10, 2022 17:33
@jottofar jottofar force-pushed the ota-661 branch 5 times, most recently from 3339825 to 18649f5 Compare June 13, 2022 13:29
wking
wking reviewed Jun 13, 2022
View reviewed changes
Comment thread enhancements/update/clusterversion-history-pruning.md Outdated
wking
wking reviewed Jun 13, 2022
View reviewed changes
Comment thread enhancements/update/clusterversion-history-pruning.md Outdated
wking
wking reviewed Jun 13, 2022
View reviewed changes
Comment thread enhancements/update/clusterversion-history-pruning.md Outdated
wking
wking reviewed Jun 13, 2022
View reviewed changes
Comment thread enhancements/update/clusterversion-history-pruning.md
wking
wking reviewed Jun 14, 2022
View reviewed changes
Comment thread enhancements/update/clusterversion-history-pruning.md Outdated
wking
wking approved these changes Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@LalatenduMohanty
Copy link
Copy Markdown
Member

LalatenduMohanty commented Jun 23, 2022

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@LalatenduMohanty
Copy link
Copy Markdown
Member

LalatenduMohanty commented Jun 23, 2022 •
edited
Loading

/hold I am not mentioned as an approver for this PR

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2022
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Jun 24, 2022

Seems fine to me.
/approve
/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 24, 2022

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit 94a1029 into openshift:master Jun 24, 2022
@wking wking mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jottofar @LalatenduMohanty @sdodson @wking