Skip to content

OCPCLOUD-2011: Update implementation history of External platform type EP#1378

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
adriengentil:api-platform-external
Jun 27, 2023
Merged

OCPCLOUD-2011: Update implementation history of External platform type EP#1378
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
adriengentil:api-platform-external

Conversation

@adriengentil
Copy link
Copy Markdown
Contributor

This PR updates the implementation history of the External platform with
the upcoming change in openshift/api.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 5, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 5, 2023

@adriengentil: This pull request references OCPCLOUD-2011 which is a valid jira issue.

Details

In response to this:

This PR updates the implementation history of the External platform with
the upcoming change in openshift/api.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2023
@openshift-ci openshift-ci Bot requested review from bparees and sttts April 5, 2023 13:23
Comment thread enhancements/cloud-integration/infrastructure-external-platform-type.md Outdated
@bparees
Copy link
Copy Markdown
Contributor

bparees commented Apr 5, 2023

/approve

thanks for keeping the history updated

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@adriengentil adriengentil force-pushed the api-platform-external branch from 68a5a10 to 8a9e37d Compare April 5, 2023 14:00
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@elmiko
Copy link
Copy Markdown
Contributor

elmiko commented Apr 6, 2023

@JoelSpeed and i discussed this today and i think we've got more questions about the best place to put this field. essentially we have some thoughts about if this should be in the spec or status, and what the most appropriate usage is for users.

/lgtm cancel

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@adriengentil adriengentil force-pushed the api-platform-external branch from ecb3974 to b17a9f9 Compare April 25, 2023 09:08
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these updates look nice to me, i'm not sure we want to add any language about how the status will be reconciled. perhaps we should add those details as followup when we get closer to deciding how it will work.

@elmiko
Copy link
Copy Markdown
Contributor

elmiko commented Apr 25, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@adriengentil
Copy link
Copy Markdown
Contributor Author

these updates look nice to me, i'm not sure we want to add any language about how the status will be reconciled. perhaps we should add those details as followup when we get closer to deciding how it will work.

yes, this is what I was thinking, to update this enhancement once we have a clearer picture on how the reconciliation will work.

@adriengentil adriengentil force-pushed the api-platform-external branch from b17a9f9 to d7bf8e7 Compare May 3, 2023 09:58
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@adriengentil
Copy link
Copy Markdown
Contributor Author

As agreed with @elmiko and @JoelSpeed, I updated the document to control the Cloud Controller Manager state from the status as this setting will be set at installation time and we won't allow it to be changed afterwards.

Comment thread enhancements/cloud-integration/infrastructure-external-platform-type.md Outdated
@openshift-bot
Copy link
Copy Markdown

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023
@adriengentil
Copy link
Copy Markdown
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci Bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023
@adriengentil adriengentil force-pushed the api-platform-external branch from 2f3b629 to f61fe20 Compare June 15, 2023 09:49
@JoelSpeed
Copy link
Copy Markdown
Contributor

@adriengentil I think a few things changed in the final few days before we merged the API, is this still up to date?

@adriengentil
Copy link
Copy Markdown
Contributor Author

In my last commit I updated a CEL and mentioned that this new API is behind TechPreviewNoUpgrade, so think we should be good.

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates @adriengentil

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
@adriengentil
Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 27, 2023

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cb52a1a into openshift:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants