OCPCLOUD-2011: Update implementation history of External platform type EP#1378
Conversation
|
@adriengentil: This pull request references OCPCLOUD-2011 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
|
/approve thanks for keeping the history updated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
68a5a10 to
8a9e37d
Compare
|
@JoelSpeed and i discussed this today and i think we've got more questions about the best place to put this field. essentially we have some thoughts about if this should be in the spec or status, and what the most appropriate usage is for users. /lgtm cancel |
ecb3974 to
b17a9f9
Compare
elmiko
left a comment
There was a problem hiding this comment.
these updates look nice to me, i'm not sure we want to add any language about how the status will be reconciled. perhaps we should add those details as followup when we get closer to deciding how it will work.
|
/lgtm |
yes, this is what I was thinking, to update this enhancement once we have a clearer picture on how the reconciliation will work. |
b17a9f9 to
d7bf8e7
Compare
|
As agreed with @elmiko and @JoelSpeed, I updated the document to control the Cloud Controller Manager state from the status as this setting will be set at installation time and we won't allow it to be changed afterwards. |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
2f3b629 to
f61fe20
Compare
|
@adriengentil I think a few things changed in the final few days before we merged the API, is this still up to date? |
|
In my last commit I updated a CEL and mentioned that this new API is behind |
elmiko
left a comment
There was a problem hiding this comment.
thanks for the updates @adriengentil
/lgtm
|
/unhold |
|
@adriengentil: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR updates the implementation history of the External platform with
the upcoming change in
openshift/api.