Skip to content

enhancement: Automated Downstream Operator SDK#471

Closed
jmrodri wants to merge 1 commit intoopenshift:masterfrom
jmrodri:downstream-operator-sdk
Closed

enhancement: Automated Downstream Operator SDK#471
jmrodri wants to merge 1 commit intoopenshift:masterfrom
jmrodri:downstream-operator-sdk

Conversation

@jmrodri
Copy link
Copy Markdown
Contributor

@jmrodri jmrodri commented Sep 10, 2020

No description provided.

@jmrodri jmrodri changed the title Downstream Operator SDK into the OpenShift ecosystem. Downstream Operator SDK Sep 10, 2020
@jmrodri
Copy link
Copy Markdown
Contributor Author

jmrodri commented Sep 10, 2020

@jmrodri
Copy link
Copy Markdown
Contributor Author

jmrodri commented Sep 10, 2020

@jmrodri
Copy link
Copy Markdown
Contributor Author

jmrodri commented Sep 10, 2020

Copy link
Copy Markdown

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the merge script work when we have multiple z-streams from both upstream (1.1.Z,1.2.Z etc) and downstream (4.6.Z, 4.7.Z). I think we need to clarify this in the proposal.

Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
@jmrodri jmrodri force-pushed the downstream-operator-sdk branch from 4223d7c to fd5f9ea Compare September 16, 2020 17:26
@jmrodri
Copy link
Copy Markdown
Contributor Author

jmrodri commented Sep 16, 2020

@shawn-hurley @asmacdo @dhellmann can you please re-review, I've made some changes from others comments as well as the ones from this review.

Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md Outdated
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md
Comment thread enhancements/operator-sdk/downstream-operator-sdk.md
Another goal is to add a script to make it easier for developers to bring in
upstream releases into the downstream.


Copy link
Copy Markdown

@camilamacedo86 camilamacedo86 Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In sdk we setup the env to run the tests against Kind. Maybe an end goal would have the sdk/upstream tests set up to be executed against OCP. PS. I am not sure if they will work without any adjustment. It might require some effort. See that we have if is KIND load the image : https://github.com/operator-framework/operator-sdk/blob/master/test/e2e-helm/e2e_helm_suite_test.go#L117-L121. So, we might need to do spend an effort here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Since SDK downstream will become a supported offering and need to denote version compatibility with OCP, adding tests against OCP sounds like a good idea and worth having it as a goal.

@jmrodri jmrodri changed the title Downstream Operator SDK enhancement: Downstream Operator SDK Sep 18, 2020
@jmrodri jmrodri force-pushed the downstream-operator-sdk branch from 972e1a0 to 76b8ad6 Compare October 13, 2020 18:55
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmrodri
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmrodri jmrodri changed the title enhancement: Downstream Operator SDK enhancement: Automated Downstream Operator SDK Oct 13, 2020
@jmrodri
Copy link
Copy Markdown
Contributor Author

jmrodri commented Oct 13, 2020

Closing this PR since I've pivoted and completely rewrote the downstreaming enhancement. The comments in this PR will only confuse matters since the document has changed so much.

@jmrodri jmrodri closed this Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants