OCPBUGS-23562: Add file based OLM catalog and remove SQLite index commands#206
Conversation
alebedev87
force-pushed
the
add-file-based-catalog
branch
from
637fdb8 to
248fb52
Compare
alebedev87
changed the title
alebedev87
changed the title
openshift-ci-robot
added
jira/severity-low
|
@alebedev87: This pull request references Jira Issue OCPBUGS-23562, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
alebedev87
force-pushed
the
add-file-based-catalog
branch
from
248fb52 to
b6fbe27
Compare
|
/assign @rfredette |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
Bot
removed
the
lifecycle/stale
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
Bot
removed
the
lifecycle/stale
rfredette
left a comment
rfredette
left a comment
There was a problem hiding this comment.
I have a couple questions, but otherwise this looks good to me.
| CMD ["serve", "/configs"] | ||
|
|
||
| # Copy declarative config root into image at /configs | ||
| ADD catalog /configs | ||
|
|
There was a problem hiding this comment.
In ALBO's catalog.Dockerfile, it looks like opm uses a cache ("--cache-dir=/tmp/cache"). Is there a reason we'd want the cached version there but not here?
There was a problem hiding this comment.
Good catch. I don't remember exactly why they are different. Probably I generated both but for ALBO I also looked at how other operators did this. Both approaches work but I think I would align this one with ALBO (and other operators in openshift org).
| @@ -0,0 +1,14 @@ | |||
| # The base image is expected to contain | |||
| # /bin/opm (with a serve subcommand) and /bin/grpc_health_probe | |||
| FROM registry.redhat.io/openshift4/ose-operator-registry:v4.14 | |||
There was a problem hiding this comment.
Since this has been waiting for review for a while (my apologies), it looks like there are newer versions of the ose-operator-registry image. Should we update this to v4.16?
There was a problem hiding this comment.
registry.redhat.io/openshift4/ose-operator-registry image seems to be discontinued, v4.15 and v4.16 tags are not there. The 4.16 OCP documentation suggests to use registry.redhat.io/openshift4/ose-operator-registry-rhel9:v4.16. It's fine with me because we would like to migrate to RHEL9 migration in the upcoming release anyway (#227).
alebedev87
force-pushed
the
add-file-based-catalog
branch
from
b6fbe27 to
95ade09
Compare
|
/approve thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfredette The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@alebedev87: Jira Issue OCPBUGS-23562: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-23562 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6 participants
The SQLite based catalog format is deprecated since OCP 4.11. This PR adds the file based catalog which is the latest iteration of the catalog format. Creating file based catalog image doc was loosely followed to create the file based catalog. The commands which use SQLite based catalog are removed.