Clean up dependabot replaces#1970
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Mar 8, 2023
Merged
Conversation
Bring in the latest BMG so we can now `make vulncheck` to get a preview of what dependabot might complain about.
Commit acc096f in openshift#1965 added a bunch of `replace` directives to scrub library versions with known vulnerabilities out of go.sum. Turns out dependabot doesn't actually care about those -- just the ones in go.mod -- so remove them.
openshift-ci
Bot
added
the
approved
Member
Author
|
/hold until #1969 merges. |
openshift-ci
Bot
added
the
do-not-merge/hold
Member
Author
|
/assign @abutcher |
Member
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, abutcher The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit acc096f in #1965 added a bunch of
replacedirectives to scrub library versions with known vulnerabilities out of go.sum. Turns out dependabot doesn't actually care about those -- just the ones in go.mod -- so remove them.