Skip to content

WIP: Fix e2e #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csrwng wants to merge 5 commits into from
Closed

WIP: Fix e2e #226

csrwng wants to merge 5 commits into from

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Feb 19, 2019

Combines commits from #222 and #223 to see if together we get passing e2e again

Thomas Wiest and others added 3 commits February 18, 2019 15:52
Add retry logic to e2e-test.sh
261eada
@wking @csrwng
*: Bump to install-config v0.12.0
6a68bac 
Catching up with openshift/installer@dafc79f0 (Generate
Network.cluster config instead of NetworkConfig.networkoperator,
2019-01-15, openshift/installer#1013), openshift/installer@3b393da8
(pkg/types/aws/machinepool: Drop IAM-role overrides, 2019-01-30,
openshift/installer#1154), and openshift/installer@9ad20c35
(pkg/destroy/aws: Remove ClusterName consumer, 2019-01-31,
openshift/installer#1170).

The uint32 -> int32 cast is slightly dangerous, because it will
silently wrap overflowing values [1,2].  But I'll try and get the
installer updated to use unsigned types as well, and then we won't
have to worry about converting.

[1]: golang/go#19624
[2]: golang/go#30209
@wking @csrwng
vendor: Bump installer to v0.12.0
9e05044 
Generated by manually updating Gopkg.toml and then running:

  $ dep ensure

with:

  $ dep version
  dep:
   version     : v0.5.0-31-g73b3afe
   build date  : 2019-02-08
   git hash    : 73b3afe
   go version  : go1.10.3
   go compiler : gc
   platform    : linux/amd64
   features    : ImportDuringSolve=false
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 19, 2019
@wking wking mentioned this pull request Feb 19, 2019
Merged
@dgoodwin
Copy link
Contributor

dgoodwin commented Feb 20, 2019

e2e is green so I am merging this right f*#&king now.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2019

New changes are detected. LGTM label has been removed.

@csrwng
Copy link
Contributor Author

csrwng commented Feb 20, 2019

/test e2e

@csrwng
Copy link
Contributor Author

csrwng commented Feb 21, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2019

@csrwng: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e 5c4f60c link /test e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@csrwng
Copy link
Contributor Author

csrwng commented Feb 21, 2019

/close

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 21, 2019

@csrwng: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csrwng csrwng deleted the fix_e2e branch March 8, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

@twiest twiest Awaiting requested review from twiest

Assignees

@dgoodwin dgoodwin

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csrwng @dgoodwin @openshift-ci-robot @wking