use CreateOrUpdate for OLM collect profiles resources#1018
Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom Feb 15, 2022
Merged
use CreateOrUpdate for OLM collect profiles resources#1018openshift-merge-robot merged 1 commit intoopenshift:mainfrom
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
Bot
added
the
approved
| @@ -1913,8 +1913,11 @@ func (r *HostedControlPlaneReconciler) reconcileOperatorLifecycleManager(ctx con | |||
| // Collect Profiles | |||
| collectProfilesConfigMap := manifests.CollectProfilesConfigMap(hcp.Namespace) | |||
| olm.ReconcileCollectProfilesConfigMap(collectProfilesConfigMap, p.OwnerRef) | |||
Contributor
There was a problem hiding this comment.
This should be removed now or not?
sjenning
force-pushed
the
fix-olm-direct-create
branch
from
2d2d36c to
1d34f33
Compare
alvaroaleman
approved these changes
Feb 15, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@sjenning: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#583 introduced two direct calls to
Createrather thanCreateOrUpdate. The result in about half the mutating calls from the CPOs in CI being 409 Conflict on these two resources: secretpprof-certand configmapolm-collect-profiles.This PR switches to
CreateOrUpdateto avoid these calls and reduce the CPO mutating call volume by roughly 50%.Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist