Skip to content

Begin using KubeVirt as the infrastructure platform instead of None#1282

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
davidvossel:mcs-update
Apr 19, 2022
Merged

Begin using KubeVirt as the infrastructure platform instead of None#1282
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
davidvossel:mcs-update

Conversation

@davidvossel
Copy link
Copy Markdown
Contributor

The machine-config-operator had some left over logic from the old KubeVirt IPI effort that broke the KubeVirt Hypershift platform. This caused us to have to temporarily report the None platform on the infrastructure object. Otherwise we'd get a bunch of coredns and other networking related changes layered in that are no longer relevant for kubevirt+hypershift.

I updated the mco here to strip out the old KubeVirt IPI logic but leave the KubeVirt platform intact. Now we can remove the weird workaround where we used none. This is important because it's needed for us to begin integrating logic into the cso for the kubevirt-csi driver install.

Signed-off-by: David Vossel <davidvossel@gmail.com>
@openshift-ci openshift-ci Bot requested review from csrwng and sjenning April 19, 2022 16:47
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 19, 2022

@davidvossel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-nested 45c50ab link false /test e2e-aws-nested
ci/prow/e2e-kubevirt-gcp 45c50ab link false /test e2e-kubevirt-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Apr 19, 2022

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9f10071 into openshift:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants