Skip to content

sync 4.8 rhcos build metadata#170

Closed
sjenning wants to merge 1 commit intoopenshift:mainfrom
sjenning:add-4.8-rhcos
Closed

sync 4.8 rhcos build metadata#170
sjenning wants to merge 1 commit intoopenshift:mainfrom
sjenning:add-4.8-rhcos

Conversation

@sjenning
Copy link
Copy Markdown
Contributor

@sjenning sjenning commented Apr 21, 2021 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented Apr 21, 2021

/test e2e-aws

@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented Apr 22, 2021

/hold
until openshift/installer updates

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2021
@sjenning sjenning changed the title WIP: use 4.8 rhcos.json metadata use 4.8 rhcos.json metadata Apr 22, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2021
@sjenning sjenning changed the title use 4.8 rhcos.json metadata sync 4.8 rhcos build metadata May 4, 2021
@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented May 4, 2021

/hold cancel
installer has updated
https://github.com/openshift/installer/blob/release-4.8/data/data/rhcos-amd64.json

@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented May 4, 2021

/test e2e-aws

enxebre
enxebre reviewed May 4, 2021
View reviewed changes
Comment thread hypershift-operator/controllers/machineimage/static/4.8/rhcos-amd64.json
@enxebre
Copy link
Copy Markdown
Member

enxebre commented May 4, 2021

/lgtm
/hold
to cancel when e2e passes

@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented May 4, 2021

/test e2e-aws

@ironcladlou
Copy link
Copy Markdown
Contributor

ironcladlou commented May 4, 2021

Let's hold this and I'm going to open a PR to replace the static data with a dynamic metadata lookup

@ironcladlou
Copy link
Copy Markdown
Contributor

ironcladlou commented May 4, 2021

This PR would be made obsolete by #205

@sjenning
Copy link
Copy Markdown
Contributor Author

sjenning commented May 4, 2021

/close

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 4, 2021

@sjenning: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning sjenning deleted the add-4.8-rhcos branch September 13, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre enxebre left review comments

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sjenning @openshift-ci-robot @enxebre @ironcladlou