Skip to content

Pin PreviousReleaseImage#1778

Closed
enxebre wants to merge 2 commits intoopenshift:mainfrom
enxebre:prevreleaseimage
Closed

Pin PreviousReleaseImage#1778
enxebre wants to merge 2 commits intoopenshift:mainfrom
enxebre:prevreleaseimage

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Oct 3, 2022

/hold

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2022
@openshift-ci openshift-ci Bot requested review from csrwng and sjenning October 3, 2022 07:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 3, 2022

/test e2e-aws

1 similar comment
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 3, 2022

/test e2e-aws

@enxebre enxebre force-pushed the prevreleaseimage branch 2 times, most recently from 8c054c2 to be78023 Compare October 3, 2022 18:52
@enxebre enxebre mentioned this pull request Oct 4, 2022
Merged
4 tasks
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 4, 2022

/test e2e-aws
to ensure #1781 failure is legit.

enxebre added 2 commits October 4, 2022 12:35
@enxebre
Add fallback for mco flags
63a3dda 
When the CPO is at N and the NodePool.spec.release at N-1 we fail to render ignition payload because openshift/machine-config-operator#3286 broke backward compatibility.
This PRs lets it fall back to MCO previously supported flags.
@enxebre
Pin PreviousReleaseImage
130d173 
When the CPO is at N and the NodePool.spec.release at N-1 we fail to render ignition payload because openshift/machine-config-operator#3286 broke backward compatibility. This PRs lets it fall back to MCO previously supported flags.
This commit ping the image used in the upgrade test to a no broken version.
@csrwng
Copy link
Copy Markdown
Contributor

csrwng commented Oct 4, 2022

/lgtm
/hold

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 4, 2022

/test e2e-aws

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 4, 2022

=== RUN TestUpgradeControlPlane/EnsureNoCrashingPods
util.go:354: Container ovnkube-master in pod ovnkube-master-1 has a restartCount > 0 (2)

/test e2e-aws

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 4, 2022

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 130d173 link true /test e2e-aws
ci/prow/capi-provider-agent-sanity 130d173 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Oct 4, 2022

/close

@enxebre enxebre closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@csrwng csrwng

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enxebre @csrwng